From: Samuel Ortiz <samuel@sortiz.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [2.6 patch] net/irda/: proper prototypes
Date: Wed, 20 Dec 2006 00:29:43 +0200 [thread overview]
Message-ID: <20061219222942.GA4274@sortiz.org> (raw)
In-Reply-To: <20061218034626.GY10316@stusta.de>
Hi Adrian,
On Mon, Dec 18, 2006 at 04:46:26AM +0100, Adrian Bunk wrote:
> This patch adds proper prototypes for some functions in
> include/net/irda/irda.h
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
looks good to me, thanks.
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Cheers,
Samuel.
>
> ---
>
> include/net/irda/irda.h | 15 +++++++++++++++
> net/irda/irmod.c | 13 -------------
> 2 files changed, 15 insertions(+), 13 deletions(-)
>
> --- linux-2.6.20-rc1-mm1/include/net/irda/irda.h.old 2006-12-18 02:49:02.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/include/net/irda/irda.h 2006-12-18 02:58:02.000000000 +0100
> @@ -113,4 +113,19 @@
> #define IAS_IRCOMM_ID 0x2343
> #define IAS_IRLPT_ID 0x9876
>
> +struct net_device;
> +struct packet_type;
> +
> +void irda_proc_register(void);
> +void irda_proc_unregister(void);
> +
> +int irda_sysctl_register(void);
> +void irda_sysctl_unregister(void);
> +
> +int irsock_init(void);
> +void irsock_cleanup(void);
> +
> +int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev,
> + struct packet_type *ptype, struct net_device *orig_dev);
> +
> #endif /* NET_IRDA_H */
> --- linux-2.6.20-rc1-mm1/net/irda/irmod.c.old 2006-12-18 02:52:18.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/net/irda/irmod.c 2006-12-18 02:53:59.000000000 +0100
> @@ -42,19 +42,6 @@
> #include <net/irda/irttp.h> /* irttp_init */
> #include <net/irda/irda_device.h> /* irda_device_init */
>
> -/* irproc.c */
> -extern void irda_proc_register(void);
> -extern void irda_proc_unregister(void);
> -/* irsysctl.c */
> -extern int irda_sysctl_register(void);
> -extern void irda_sysctl_unregister(void);
> -/* af_irda.c */
> -extern int irsock_init(void);
> -extern void irsock_cleanup(void);
> -/* irlap_frame.c */
> -extern int irlap_driver_rcv(struct sk_buff *, struct net_device *,
> - struct packet_type *, struct net_device *);
> -
> /*
> * Module parameters
> */
>
next prev parent reply other threads:[~2006-12-19 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 3:46 [2.6 patch] net/irda/: proper prototypes Adrian Bunk
2006-12-19 22:29 ` Samuel Ortiz [this message]
2007-01-02 8:39 ` David Miller
2007-01-02 12:45 ` Adrian Bunk
2007-01-02 21:02 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2007-02-06 0:30 [patch 02/11] " akpm
2007-02-06 2:01 ` David Miller
2007-02-20 0:07 ` [2.6 patch] " Adrian Bunk
2007-02-20 9:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219222942.GA4274@sortiz.org \
--to=samuel@sortiz.org \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.