From: Adrian Bunk <bunk@stusta.de>
To: David Miller <davem@davemloft.net>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, samuel@sortiz.org
Subject: [2.6 patch] net/irda/: proper prototypes
Date: Tue, 20 Feb 2007 01:07:21 +0100 [thread overview]
Message-ID: <20070220000720.GR13958@stusta.de> (raw)
In-Reply-To: <20070205.180142.35665788.davem@davemloft.net>
On Mon, Feb 05, 2007 at 06:01:42PM -0800, David Miller wrote:
> From: akpm@linux-foundation.org
> Date: Mon, 05 Feb 2007 16:30:53 -0800
>
> > From: Adrian Bunk <bunk@stusta.de>
> >
> > Add proper prototypes for some functions in include/net/irda/irda.h
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > Acked-by: Samuel Ortiz <samuel@sortiz.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> I NAK'd this so that Adrian would go add "extern" to the
> function declarations in the header file.
>
> Please drop this, Adrian will resend once he fixes it up.
Sorry, I should have sent this earlier.
Updated patch below.
cu
Adrian
<-- snip -->
This patch adds proper prototypes for some functions in
include/net/irda/irda.h
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/net/irda/irda.h | 16 ++++++++++++++++
net/irda/irmod.c | 13 -------------
2 files changed, 16 insertions(+), 13 deletions(-)
--- linux-2.6.20-rc1-mm1/include/net/irda/irda.h.old 2006-12-18 02:49:02.000000000 +0100
+++ linux-2.6.20-rc1-mm1/include/net/irda/irda.h 2006-12-18 02:58:02.000000000 +0100
@@ -113,4 +113,20 @@
#define IAS_IRCOMM_ID 0x2343
#define IAS_IRLPT_ID 0x9876
+struct net_device;
+struct packet_type;
+
+extern void irda_proc_register(void);
+extern void irda_proc_unregister(void);
+
+extern int irda_sysctl_register(void);
+extern void irda_sysctl_unregister(void);
+
+extern int irsock_init(void);
+extern void irsock_cleanup(void);
+
+extern int irlap_driver_rcv(struct sk_buff *skb, struct net_device *dev,
+ struct packet_type *ptype,
+ struct net_device *orig_dev);
+
#endif /* NET_IRDA_H */
--- linux-2.6.20-rc1-mm1/net/irda/irmod.c.old 2006-12-18 02:52:18.000000000 +0100
+++ linux-2.6.20-rc1-mm1/net/irda/irmod.c 2006-12-18 02:53:59.000000000 +0100
@@ -42,19 +42,6 @@
#include <net/irda/irttp.h> /* irttp_init */
#include <net/irda/irda_device.h> /* irda_device_init */
-/* irproc.c */
-extern void irda_proc_register(void);
-extern void irda_proc_unregister(void);
-/* irsysctl.c */
-extern int irda_sysctl_register(void);
-extern void irda_sysctl_unregister(void);
-/* af_irda.c */
-extern int irsock_init(void);
-extern void irsock_cleanup(void);
-/* irlap_frame.c */
-extern int irlap_driver_rcv(struct sk_buff *, struct net_device *,
- struct packet_type *, struct net_device *);
-
/*
* Module parameters
*/
next prev parent reply other threads:[~2007-02-20 0:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 0:30 [patch 02/11] net/irda/: proper prototypes akpm
2007-02-06 2:01 ` David Miller
2007-02-20 0:07 ` Adrian Bunk [this message]
2007-02-20 9:05 ` [2.6 patch] " David Miller
-- strict thread matches above, loose matches on Subject: below --
2006-12-18 3:46 Adrian Bunk
2006-12-19 22:29 ` Samuel Ortiz
2007-01-02 8:39 ` David Miller
2007-01-02 12:45 ` Adrian Bunk
2007-01-02 21:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220000720.GR13958@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.