Re: [PATCH] two missing bits (was Re: Add -Wcast-qual flag)

["Christoph Egger" <Christoph.Egger@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

On Friday 22 December 2006 10:40, Keir Fraser wrote:
> Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast
> hidden inside the ADDR macro is dropping the const qualifier.

That's right. Yet another alternative patch, this time with the CONST_ADDR 
macro.


>  -- Keir
>
> On 22/12/06 9:31 am, "Jan Beulich" <jbeulich@novell.com> wrote:
> > I object to the change to variable_test_bit() - why is that needed? I had
> > specifically
> > submitted a patch to get the const qualifier added there. Jan

[-- Attachment #2: xen-cast-xen.diff --]
[-- Type: text/x-diff, Size: 969 bytes --]

diff -r f1ddc050d848 xen/common/gdbstub.c
--- a/xen/common/gdbstub.c	Thu Dec 21 20:44:35 2006 +0000
+++ b/xen/common/gdbstub.c	Fri Dec 22 09:51:42 2006 +0100
@@ -382,7 +382,7 @@ static int
 static int 
 process_command(struct cpu_user_regs *regs, struct gdb_context *ctx)
 {
-    char *ptr;
+    const char *ptr;
     unsigned long addr, length;
     int resume = 0;
 
diff -r f1ddc050d848 xen/include/asm-x86/bitops.h
--- a/xen/include/asm-x86/bitops.h	Thu Dec 21 20:44:35 2006 +0000
+++ b/xen/include/asm-x86/bitops.h	Fri Dec 22 10:47:50 2006 +0100
@@ -22,6 +22,7 @@
  * used only when the constraint allows the operand to reside in a register.
  */
 
+#define CONST_ADDR (*(const volatile long *) addr)
 #define ADDR (*(volatile long *) addr)
 
 /**
@@ -253,7 +254,7 @@ static __inline__ int variable_test_bit(
 	__asm__ __volatile__(
 		"btl %2,%1\n\tsbbl %0,%0"
 		:"=r" (oldbit)
-		:"m" (ADDR),"dIr" (nr));
+		:"m" (CONST_ADDR),"dIr" (nr));
 	return oldbit;
 }
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel