From: "Jan Beulich" <jbeulich@novell.com>
To: Christoph Egger <Christoph.Egger@amd.com>,
Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
Subject: Re: [PATCH] two missing bits (was Re: Add -Wcast-qual flag)
Date: Fri, 22 Dec 2006 09:51:41 +0000 [thread overview]
Message-ID: <458BB8BD.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C1B15874.628F%Keir.Fraser@cl.cam.ac.uk>
If this was with -Wconst-qual, yes. But didn't we agree that at least for now we'll
not add that warning (and hence we also don't absolutely have to change code
only affected by it)? Jan
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 22.12.06 10:40 >>>
Maybe we need a CONST_ADDR macro, as I suspect the problem is the cast
hidden inside the ADDR macro is dropping the const qualifier.
-- Keir
On 22/12/06 9:31 am, "Jan Beulich" <jbeulich@novell.com> wrote:
> I object to the change to variable_test_bit() - why is that needed? I had
> specifically
> submitted a patch to get the const qualifier added there. Jan
>
>>>> "Christoph Egger" <Christoph.Egger@amd.com> 22.12.06 10:05 >>>
>
> Hi!
>
> I catched two pieces with debug and crash_debug enabled.
> One of them fixes a build error even without the -Wcast-qual flag.
>
> Patch attached.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2006-12-22 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 9:05 [PATCH] two missing bits (was Re: Add -Wcast-qual flag) Christoph Egger
2006-12-22 9:31 ` Jan Beulich
2006-12-22 9:40 ` Keir Fraser
2006-12-22 9:51 ` Jan Beulich [this message]
2006-12-22 9:55 ` Christoph Egger
2006-12-22 9:52 ` Christoph Egger
2006-12-22 9:44 ` Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458BB8BD.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Christoph.Egger@amd.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=keir@xensource.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.