From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jgarzik@pobox.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
linux-scsi@vger.kernel.org
Subject: [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl
Date: Tue, 2 Jan 2007 17:24:39 -0500 [thread overview]
Message-ID: <200701021724.39613.liml@rtr.ca> (raw)
With recent kernels (and possibly much older ones, too),
ioctl() calls for ATAPI devices never make it to the driver layers.
The reason for this is a borked return code test in drivers/scsi/sr.c.
This patch fixes it.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
--- old/drivers/scsi/sr.c 2006-11-29 16:57:37.000000000 -0500
+++ linux/drivers/scsi/sr.c 2007-01-02 16:40:33.000000000 -0500
@@ -468,7 +468,7 @@
}
ret = cdrom_ioctl(file, &cd->cdi, inode, cmd, arg);
- if (ret != ENOSYS)
+ if (ret != -ENOSYS)
return ret;
/*
next reply other threads:[~2007-01-02 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 22:24 Mark Lord [this message]
2007-01-02 22:30 ` [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Mark Lord
2007-01-02 22:32 ` [PATCH] Add ATA_12/ATA_16 support for libata ATAPI Mark Lord
2007-01-02 22:36 ` [PATCH] libata use ATA_12 in HDIO_* ioctls for ATAPI compatibility Mark Lord
2007-01-03 0:23 ` Mark Lord
2007-01-02 22:37 ` [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Jeff Garzik
2007-01-02 22:52 ` Mark Lord
2007-01-02 23:12 ` Mark Lord
2007-01-03 3:36 ` Douglas Gilbert
2007-01-02 22:32 ` Jeff Garzik
2007-01-02 22:39 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701021724.39613.liml@rtr.ca \
--to=liml@rtr.ca \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.