All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Tejun Heo <htejun@gmail.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Douglas Gilbert <dougg@torque.net>
Subject: Re: [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl
Date: Tue, 02 Jan 2007 18:12:27 -0500	[thread overview]
Message-ID: <459AE6DB.1020001@rtr.ca> (raw)
In-Reply-To: <459AE23B.1020904@rtr.ca>

Mark Lord wrote:
> Jeff Garzik wrote:
>> Mark Lord wrote:
> ..
>>> Allow ATA_12 / ATA_16 passthru commands to be issued for ATAPI devices
..
> Mmmm.. yes, the "BLANK" opcode is indeed the same as ATA_12.

Yup, BLANK is commonly used with CD-RW software (cdrecord, k3b, ..),
so we cannot translate ATA_12 for ATAPI CD devices.

How about a hack to the upper layer (scsi, or block??) to allow ATA_16
even when the max_cmd_len is 12 ??  In reality, the command length is
unimportant in that case, so it's more a matter of tastefulness than anything.

???

  reply	other threads:[~2007-01-02 23:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-02 22:24 [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Mark Lord
2007-01-02 22:30 ` Mark Lord
2007-01-02 22:32   ` [PATCH] Add ATA_12/ATA_16 support for libata ATAPI Mark Lord
2007-01-02 22:36     ` [PATCH] libata use ATA_12 in HDIO_* ioctls for ATAPI compatibility Mark Lord
2007-01-03  0:23       ` Mark Lord
2007-01-02 22:37   ` [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Jeff Garzik
2007-01-02 22:52     ` Mark Lord
2007-01-02 23:12       ` Mark Lord [this message]
2007-01-03  3:36         ` Douglas Gilbert
2007-01-02 22:32 ` Jeff Garzik
2007-01-02 22:39   ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459AE6DB.1020001@rtr.ca \
    --to=liml@rtr.ca \
    --cc=akpm@osdl.org \
    --cc=dougg@torque.net \
    --cc=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.