From: tony@atomide.com
To: Dirk Behme <dirk.behme@googlemail.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: ISP1301 workqueue fixes
Date: Tue, 2 Jan 2007 12:34:27 -0800 [thread overview]
Message-ID: <20070102203427.GC9733@atomide.com> (raw)
In-Reply-To: <4594D386.2050904@gmail.com>
* Dirk Behme <dirk.behme@googlemail.com> [061229 00:44]:
> David Brownell wrote:
> >On Thursday 28 December 2006 12:02 am, Dirk Behme wrote:
> >
> >>static void
> >>-isp1301_work(void *data)
> >>+isp1301_work(struct work_struct *data)
> >>{
> >>- struct isp1301 *isp = data;
> >>+ struct isp1301 *isp = (struct isp1301 *)data;
> >> int stop;
> >
> >
> >Clearly incorrect. It should use container_of(). The work_struct
> >is NOT the first member of that struct... this will be oopsing.
>
> Yes, I see. Thanks!
>
> So, next attempt ;) Below both, ISP1301 and board-h3. Again,
> only checked for compilation.
Pushing as two patches.
Tony
prev parent reply other threads:[~2007-01-02 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 8:02 [PATCH] ARM: OMAP: ISP1301 workqueue fixes Dirk Behme
2006-12-28 12:30 ` Komal Shah
2006-12-28 16:19 ` Dirk Behme
2006-12-28 20:07 ` David Brownell
2006-12-28 20:05 ` David Brownell
2006-12-29 8:36 ` Dirk Behme
2007-01-02 20:34 ` tony [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070102203427.GC9733@atomide.com \
--to=tony@atomide.com \
--cc=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.