From: Dirk Behme <dirk.behme@googlemail.com>
To: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: ISP1301 workqueue fixes
Date: Thu, 28 Dec 2006 17:19:37 +0100 [thread overview]
Message-ID: <4593EE99.9080108@gmail.com> (raw)
In-Reply-To: <3a5b1be00612280430u5117383eme98f2d1ce50c411f@mail.gmail.com>
Komal Shah wrote:
> On 12/28/06, Dirk Behme <dirk.behme@googlemail.com> wrote:
...
>> Index: linux-osk/drivers/i2c/chips/isp1301_omap.c
>> ===================================================================
>> --- linux-osk.orig/drivers/i2c/chips/isp1301_omap.c
>> +++ linux-osk/drivers/i2c/chips/isp1301_omap.c
>> @@ -1119,9 +1119,9 @@ static u8 isp1301_clear_latch(struct isp
>> }
>>
>> static void
>> -isp1301_work(void *data)
>> +isp1301_work(struct work_struct *data)
>> {
>> - struct isp1301 *isp = data;
>> + struct isp1301 *isp = (struct isp1301 *)data;
>
>
> Why not use container_of ? Did you tested it?
Can anybody with H2/H3 board test this? Same with board-h3
workqueue fix from Ragner.
Many thanks
Dirk
next prev parent reply other threads:[~2006-12-28 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 8:02 [PATCH] ARM: OMAP: ISP1301 workqueue fixes Dirk Behme
2006-12-28 12:30 ` Komal Shah
2006-12-28 16:19 ` Dirk Behme [this message]
2006-12-28 20:07 ` David Brownell
2006-12-28 20:05 ` David Brownell
2006-12-29 8:36 ` Dirk Behme
2007-01-02 20:34 ` tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4593EE99.9080108@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.