[PATCH 4/4][NEW]: More to see in dccp_probe

[PATCH 4/4][NEW]: More to see in dccp_probe

[Gerrit Renker]

[CCID 3]: More to see in dccp_probe

This removes the `size' field from output (which would report the constant buffer size),
and adds a few more fields of interest to /proc/net/dccpprobe, the following output ensues:

sec.usec   src:sport   dst:dport   s   rtt   p   X_calc  X_recv   X   t_ipi
1           2          3           4   5     6   7       8        9   10

Scripts that go with this can be downloaded from http://139.133.210.30/users/gerrit/dccp/dccp_probe/

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
---
 net/dccp/probe.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- a/net/dccp/probe.c
+++ b/net/dccp/probe.c
@@ -90,11 +90,13 @@ static int jdccp_sendmsg(struct kiocb *i
 	if (port = 0 || ntohs(inet->dport) = port ||
 	    ntohs(inet->sport) = port) {
 		if (hctx)
-			printl("%d.%d.%d.%d:%u %d.%d.%d.%d:%u %d %d %d %d %d\n",
+			printl("%d.%d.%d.%d:%u %d.%d.%d.%d:%u %d %d %d %u %llu %llu %d\n",
 			   NIPQUAD(inet->saddr), ntohs(inet->sport),
-			   NIPQUAD(inet->daddr), ntohs(inet->dport), size,
+			   NIPQUAD(inet->daddr), ntohs(inet->dport),
 			   hctx->ccid3hctx_s, hctx->ccid3hctx_rtt,
-			   hctx->ccid3hctx_p, hctx->ccid3hctx_t_ipi);
+			   hctx->ccid3hctx_p,
+			   hctx->ccid3hctx_x_calc, hctx->ccid3hctx_x_recv >> 6,
+			   hctx->ccid3hctx_x >> 6, hctx->ccid3hctx_t_ipi);
 		else
 			printl("%d.%d.%d.%d:%u %d.%d.%d.%d:%u %d\n",
 			   NIPQUAD(inet->saddr), ntohs(inet->sport),

Re: [PATCH 4/4][NEW]: More to see in dccp_probe

[Ian McDonald]

On 1/4/07, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> [CCID 3]: More to see in dccp_probe
>
> This removes the `size' field from output (which would report the constant buffer size),
> and adds a few more fields of interest to /proc/net/dccpprobe, the following output ensues:
>
I would like the size field kept. This is not constant if you are
sending different size packets like I am :-) It is only constant if
you are using something like iperf/ttcp.

Ian
-- 
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group

Re: [PATCH 4/4][NEW]: More to see in dccp_probe

[@ 2007-01-04 3:04 UTC (permalink / raw)]

In article <5640c7e00701031339u20f7ad2hf416821257f44214@mail.gmail.com> (at Thu, 4 Jan 2007 10:39:18 +1300), "Ian McDonald" <ian.mcdonald@jandi.co.nz> says:

> On 1/4/07, Gerrit Renker <gerrit@erg.abdn.ac.uk> wrote:
> > [CCID 3]: More to see in dccp_probe
> >
> > This removes the `size' field from output (which would report the constant buffer size),
> > and adds a few more fields of interest to /proc/net/dccpprobe, the following output ensues:
> >
> I would like the size field kept. This is not constant if you are
> sending different size packets like I am :-) It is only constant if
> you are using something like iperf/ttcp.

I agree, and please do not insert new fields
but add them to the tail of old fields.

--yoshfuji