From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
Douglas Gilbert <dougg@torque.net>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_debug: illegal blocking memory allocation
Date: Thu, 4 Jan 2007 08:27:48 -0700 [thread overview]
Message-ID: <20070104152748.GE24620@parisc-linux.org> (raw)
In-Reply-To: <1167923401.2819.7.camel@mulgrave.il.steeleye.com>
On Thu, Jan 04, 2007 at 09:10:01AM -0600, James Bottomley wrote:
> On Thu, 2007-01-04 at 12:21 +0100, Jens Axboe wrote:
> > I guess it's fully up to you how you want to solve it. The scheme seems
> > a little elaborate, but these error conditions are unlikely to ever been
> > seen in the wild, so no objections from me.
>
> Actually, there's already a DID_ code that does what you want. Instead
> of DID_ERROR, which will retry immediately, there's DID_REQUEUE which
> will halt the device queue and wait for a returning command to retry.
Any returning command, or a returning command from this device? We may
be out of memory from a different device, and this may be the only
command being sent to the scsi_debug driver. Wouldn't we end up
halting the device queue indefinitely then?
next prev parent reply other threads:[~2007-01-04 15:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 13:49 [PATCH] scsi_debug: illegal blocking memory allocation Jens Axboe
2007-01-04 5:38 ` Douglas Gilbert
2007-01-04 11:21 ` Jens Axboe
2007-01-04 15:10 ` James Bottomley
2007-01-04 15:27 ` Matthew Wilcox [this message]
2007-01-04 15:34 ` James Bottomley
2007-01-04 15:50 ` Jens Axboe
2007-01-05 5:30 ` Douglas Gilbert
2007-01-05 12:49 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070104152748.GE24620@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=dougg@torque.net \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.