[PATCH] Add const for time{spec,val}_compare arguments

[PATCH] Add const for time{spec,val}_compare arguments

[Rolf Eike Beer]

The arguments are really const. Mark them const to allow these functions
being called from places where the arguments are const without getting
useless compiler warnings.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

---
commit aa6af3ef5a9708b1b81aa4b6b0d30c578ac1b29c
tree 157e65f05bcb7aac859186c944573f5d40935564
parent 213bcc9bc614154948b6f83cbb872ea046557598
author Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 13 Dec 2006 09:46:58 +0100
committer Rolf Eike Beer <eike-kernel@sf-tec.de> Wed, 13 Dec 2006 09:46:58 +0100

 include/linux/time.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/time.h b/include/linux/time.h
index a5b7399..55cee17 100644
--- a/include/linux/time.h
+++ b/include/linux/time.h
@@ -46,7 +46,7 @@ static inline int timespec_equal(struct timespec *a, struct timespec *b)
  * lhs == rhs: return 0
  * lhs > rhs:  return >0
  */
-static inline int timespec_compare(struct timespec *lhs, struct timespec *rhs)
+static inline int timespec_compare(const struct timespec *lhs, const struct timespec *rhs)
 {
 	if (lhs->tv_sec < rhs->tv_sec)
 		return -1;
@@ -55,7 +55,7 @@ static inline int timespec_compare(struct timespec *lhs, struct timespec *rhs)
 	return lhs->tv_nsec - rhs->tv_nsec;
 }
 
-static inline int timeval_compare(struct timeval *lhs, struct timeval *rhs)
+static inline int timeval_compare(const struct timeval *lhs, const struct timeval *rhs)
 {
 	if (lhs->tv_sec < rhs->tv_sec)
 		return -1;

Re: [PATCH] Add const for time{spec,val}_compare arguments

[Jan Engelhardt]

On Jan 4 2007 16:59, Rolf Eike Beer wrote:
>From: Rolf Eike Beer <eike-kernel@sf-tec.de>
>To: linux-kernel@vger.kernel.org
>Cc: Andrew Morton <akpm@osdl.org>
>Subject: [PATCH] Add const for time{spec,val}_compare arguments
>
>The arguments are really const. Mark them const to allow these functions
>being called from places where the arguments are const without getting
>useless compiler warnings.
>
>Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>


It's already been done: http://lkml.org/lkml/2006/7/27/299
Now, I wonder why it got not merged yet.


	-`J'
--