[PATCH 5/9] KVM: Don't set guest cr3 from vmx_vcpu_setup()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu
Subject: [PATCH 5/9] KVM: Don't set guest cr3 from vmx_vcpu_setup()
Date: Fri, 05 Jan 2007 07:54:45 -0000	[thread overview]
Message-ID: <20070105075445.722EE250048@il.qumranet.com> (raw)
In-Reply-To: <459E02E7.5020407@qumranet.com>

It overwrites the right cr3 set from mmu setup.  Happens only with the test harness.

Signed-off-by: Avi Kivity <avi@qumranet.com>

Index: linux-2.6/drivers/kvm/vmx.c
===================================================================
--- linux-2.6.orig/drivers/kvm/vmx.c
+++ linux-2.6/drivers/kvm/vmx.c
@@ -1027,8 +1027,6 @@ static int vmx_vcpu_setup(struct kvm_vcp
 	vmcs_writel(GUEST_RIP, 0xfff0);
 	vmcs_writel(GUEST_RSP, 0);
 
-	vmcs_writel(GUEST_CR3, 0);
-
 	//todo: dr0 = dr1 = dr2 = dr3 = 0; dr6 = 0xffff0ff0
 	vmcs_writel(GUEST_DR7, 0x400);

WARNING: multiple messages have this Message-ID (diff)

From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: akpm-3NddpPZAyC0@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 5/9] KVM: Don't set guest cr3 from vmx_vcpu_setup()
Date: Fri, 05 Jan 2007 07:54:45 -0000	[thread overview]
Message-ID: <20070105075445.722EE250048@il.qumranet.com> (raw)
In-Reply-To: <459E02E7.5020407-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

It overwrites the right cr3 set from mmu setup.  Happens only with the test harness.

Signed-off-by: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

Index: linux-2.6/drivers/kvm/vmx.c
===================================================================
--- linux-2.6.orig/drivers/kvm/vmx.c
+++ linux-2.6/drivers/kvm/vmx.c
@@ -1027,8 +1027,6 @@ static int vmx_vcpu_setup(struct kvm_vcp
 	vmcs_writel(GUEST_RIP, 0xfff0);
 	vmcs_writel(GUEST_RSP, 0);
 
-	vmcs_writel(GUEST_CR3, 0);
-
 	//todo: dr0 = dr1 = dr2 = dr3 = 0; dr6 = 0xffff0ff0
 	vmcs_writel(GUEST_DR7, 0x400);
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

next prev parent reply	other threads:[~2007-01-05  7:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05  7:48 [PATCH 0/9] KVM: Flush out my patch queue Avi Kivity
2007-01-05  7:48 ` Avi Kivity
2007-01-05  7:50 ` [PATCH 1/9] KVM: Improve reporting of vmwrite errors Avi Kivity
2007-01-05  7:50   ` Avi Kivity
2007-01-05  7:51 ` [PATCH 2/9] KVM: Initialize vcpu->kvm a little earlier Avi Kivity
2007-01-05  7:51   ` Avi Kivity
2007-01-05  7:52 ` [PATCH 3/9] KVM: Avoid oom on cr3 switch Avi Kivity
2007-01-05  7:52   ` Avi Kivity
2007-01-05  7:53 ` [PATCH 4/9] KVM: Add missing 'break' Avi Kivity
2007-01-05  7:53   ` Avi Kivity
2007-01-05  7:54 ` Avi Kivity [this message]
2007-01-05  7:54   ` [PATCH 5/9] KVM: Don't set guest cr3 from vmx_vcpu_setup() Avi Kivity
2007-01-05  7:55 ` [PATCH 6/9] KVM: MMU: Add missing dirty bit Avi Kivity
2007-01-05  7:55   ` Avi Kivity
2007-01-05  7:56 ` [PATCH 7/9] KVM: Make loading cr3 more robust Avi Kivity
2007-01-05  7:56   ` Avi Kivity
2007-01-05  7:57 ` [PATCH 8/9] KVM: Simplify mmu_alloc_roots() Avi Kivity
2007-01-05  7:57   ` Avi Kivity
2007-01-05  7:58 ` [PATCH 9/9] KVM: Simplify test for interrupt window Avi Kivity
2007-01-05  7:58   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070105075445.722EE250048@il.qumranet.com \
    --to=avi@qumranet.com \
    --cc=akpm@osdl.org \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.