All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horms <horms@verge.net.au>
To: Ian Campbell <Ian.Campbell@xensource.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH] kexec/kdump: fix grammar in comment
Date: Thu, 11 Jan 2007 12:35:34 +0900	[thread overview]
Message-ID: <20070111033533.GA8726@verge.net.au> (raw)
In-Reply-To: <1168421358.24570.25.camel@localhost.localdomain>

On Wed, Jan 10, 2007 at 09:29:18AM +0000, Ian Campbell wrote:
> On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> > Fix the grammar in the comment that features in
> > xen_machine_kexec_setup_resources(). The current
> > edition is a bit odd.
> 
> What I was trying to say is that we allow a possible memory leak because
> the failure is unexpected and the amount is small, your version doesn't
> really convey that information.
> 
> I've changed it to:
> 
>       * It isn't possible to free xen_phys_cpus this early in the 
>       * boot. Failure at this stage is unexpected and the
>       * amount of memory is small therefore we tolerate the
>       * potential leak.

Thanks.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

  reply	other threads:[~2007-01-11  3:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-10  8:03 [PATCH] kexec/kdump: fix grammar in comment Horms
2007-01-10  9:29 ` Ian Campbell
2007-01-11  3:35   ` Horms [this message]
2007-01-10 10:39 ` Keir Fraser
  -- strict thread matches above, loose matches on Subject: below --
2006-12-27  4:29 Horms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070111033533.GA8726@verge.net.au \
    --to=horms@verge.net.au \
    --cc=Ian.Campbell@xensource.com \
    --cc=magnus.damm@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.