From: Christoph Hellwig <hch@infradead.org>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: Roland Dreier <rdreier@cisco.com>,
linux-kernel@vger.kernel.org, openib-general@openib.org,
openfabrics-ewg@openib.org, hch@infradead.org,
linuxppc-dev@ozlabs.org, raisch@de.ibm.com
Subject: Re: [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures
Date: Thu, 11 Jan 2007 19:14:25 +0000 [thread overview]
Message-ID: <20070111191425.GA24623@infradead.org> (raw)
In-Reply-To: <200701112007.49620.hnguyen@linux.vnet.ibm.com>
On Thu, Jan 11, 2007 at 08:07:49PM +0100, Hoang-Nam Nguyen wrote:
> -#define ehca_alloc_fw_ctrlblock(flags) ((void *) get_zeroed_page(flags))
> +#define ehca_alloc_fw_ctrlblock(flags) ((void*) get_zeroed_page(flags))
This indentation changes moves away from the preffered form.
Except for that the patch looks fine.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: Roland Dreier <rdreier@cisco.com>,
hch@infradead.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, openfabrics-ewg@openib.org,
openib-general@openib.org, raisch@de.ibm.com
Subject: Re: [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures
Date: Thu, 11 Jan 2007 19:14:25 +0000 [thread overview]
Message-ID: <20070111191425.GA24623@infradead.org> (raw)
In-Reply-To: <200701112007.49620.hnguyen@linux.vnet.ibm.com>
On Thu, Jan 11, 2007 at 08:07:49PM +0100, Hoang-Nam Nguyen wrote:
> -#define ehca_alloc_fw_ctrlblock(flags) ((void *) get_zeroed_page(flags))
> +#define ehca_alloc_fw_ctrlblock(flags) ((void*) get_zeroed_page(flags))
This indentation changes moves away from the preffered form.
Except for that the patch looks fine.
next prev parent reply other threads:[~2007-01-11 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-11 19:07 [PATCH/RFC 2.6.21 1/5] ehca: declaration of queue structures Hoang-Nam Nguyen
2007-01-11 19:14 ` Christoph Hellwig [this message]
2007-01-11 19:14 ` Christoph Hellwig
2007-01-11 19:17 ` Roland Dreier
2007-01-11 19:17 ` Roland Dreier
2007-01-11 19:22 ` Christoph Hellwig
2007-01-11 19:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111191425.GA24623@infradead.org \
--to=hch@infradead.org \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openfabrics-ewg@openib.org \
--cc=openib-general@openib.org \
--cc=raisch@de.ibm.com \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.