From: fork0@t-online.de (Alex Riesen)
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] Speedup recursive by flushing index only once for all entries
Date: Thu, 11 Jan 2007 22:48:26 +0100 [thread overview]
Message-ID: <20070111214826.GC6058@steel.home> (raw)
In-Reply-To: <Pine.LNX.4.64.0701111001150.3594@woody.osdl.org>
Linus Torvalds, Thu, Jan 11, 2007 19:02:52 +0100:
> > > That said, I think we actually have another problem entirely:
> > >
> > > Look at "write_cache()", Junio: isn't it leaking memory like mad?
> >
> > Unless it is used in some corner case not covered by tests - it
> > looks like it does leak memory like mad. With the patch the
> > memory usage for 44k-merge is more than halved!
>
> Is that halving on _top_ of your and Junio's fixes to not flush
> unnecessarily?
Yes.
> And it does pass all the tests, although I don't know how much coverage
> they have in this area..
Quite a bit: criss-cross, renames, simple. My 44k-merge is just a
primitive two-head merge useful only as a stress test (it doesn't even
has any renames).
next prev parent reply other threads:[~2007-01-11 21:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 10:47 [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-04 12:33 ` Johannes Schindelin
2007-01-04 12:47 ` Alex Riesen
2007-01-04 20:22 ` Junio C Hamano
2007-01-05 11:22 ` Alex Riesen
2007-01-07 16:31 ` Alex Riesen
2007-01-10 18:06 ` Junio C Hamano
2007-01-10 19:28 ` Junio C Hamano
2007-01-10 22:11 ` Junio C Hamano
2007-01-10 23:07 ` Alex Riesen
2007-01-10 23:23 ` Linus Torvalds
2007-01-11 8:14 ` Johannes Schindelin
2007-01-11 9:03 ` Alex Riesen
2007-01-11 12:11 ` Alex Riesen
2007-01-11 20:37 ` Junio C Hamano
2007-01-11 9:02 ` Alex Riesen
2007-01-11 16:38 ` Linus Torvalds
2007-01-11 17:43 ` Alex Riesen
2007-01-11 18:02 ` Linus Torvalds
2007-01-11 21:48 ` Alex Riesen [this message]
2007-01-11 20:23 ` Junio C Hamano
2007-01-11 22:10 ` Alex Riesen
2007-01-11 22:28 ` Linus Torvalds
2007-01-11 23:53 ` Junio C Hamano
2007-01-12 0:18 ` Alex Riesen
2007-01-11 0:34 ` Junio C Hamano
2007-01-11 8:15 ` Johannes Schindelin
2007-01-12 15:48 ` Sergey Vlasov
2007-01-12 17:38 ` Alex Riesen
2007-01-12 20:37 ` Sergey Vlasov
2007-01-12 18:23 ` Junio C Hamano
2007-01-12 20:09 ` [PATCH] merge-recursive: do not report the resulting tree object name Junio C Hamano
2007-01-12 23:36 ` Johannes Schindelin
2007-01-13 0:32 ` Junio C Hamano
2007-01-13 0:57 ` Jakub Narebski
2007-01-13 11:01 ` Johannes Schindelin
2007-01-13 5:14 ` Shawn O. Pearce
2007-01-13 7:03 ` Junio C Hamano
2007-01-12 20:30 ` [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-12 21:07 ` Sergey Vlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070111214826.GC6058@steel.home \
--to=fork0@t-online.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.