All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] merge-recursive: do not report the resulting tree object name
Date: Fri, 12 Jan 2007 16:32:59 -0800	[thread overview]
Message-ID: <7vbql3pxz8.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0701130034000.22628@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Sat, 13 Jan 2007 00:36:09 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> I like this patch. merge-recursive is very talkative, to the intimidating 
> astonishment of unsuspecting users.

This is a smallish example:

        $ git merge jc/merge-base
     1	Trying really trivial in-index merge...
     2	fatal: Merge requires file-level merging
     3	Nope.
     4	Merging HEAD with jc/merge-base
     5	Merging:
     6	b60daf0 Make git-prune-packed a bit more chatty.
     7	5b75a55 Teach "git-merge-base --check-ancestry" about refs.
     8	found 1 common ancestor(s):
     9	1c23d79 Don't die in git-http-fetch when fetching packs.
    10	Auto-merging Makefile
    11	Auto-merging builtin-branch.c
    12	Auto-merging builtin-reflog.c
    13	CONFLICT (content): Merge conflict in builtin-reflog.c
    14	Auto-merging builtin.h
    15	Auto-merging git.c
    16	Removing merge-base.c
    17	Resolved 'builtin-reflog.c' using previous resolution.
    18	Automatic merge failed; fix conflicts and then commit the result.

Among these, I think lines 2..3 are somewhat confusing but I am
used to seeing them and do not mind them too much.

Lines 4..9 do not have any real information that helps the end
user (even though it would be a very good debugging aid for
merge-recursive developers).

Lines 10..16 are useful, but I think we probably should show
them only for outermost merges.

An multi-base example:

        $ git merge 82560983997c961d9deafe0074b787c8484c2e1d
     1	Merging HEAD with 82560983997c961d9deafe0074b787c8484c2e1d
     2	Merging:
     3	9ee93dc Merge for-each-ref to sync gitweb fully with 'next'...
     4	8256098 gitweb: Print commit message without title in commi...
     5	found 2 common ancestor(s):
     6	b2d3476 Gitweb - provide site headers and footers
     7	1259404 Merge branch 'maint'
     8	  Merging:
     9	  b2d3476 Gitweb - provide site headers and footers
    10	  1259404 Merge branch 'maint'
    11	  found 1 common ancestor(s):
    12	  128eead gitweb: document webserver configuration for comm...
    13	  Auto-merging Makefile
    14	  Auto-merging gitweb/gitweb.perl
    15	  CONFLICT (content): Merge conflict in gitweb/gitweb.perl
    16	Auto-merging gitweb/gitweb.perl
    17	Merge made by recursive.
    18	 gitweb/gitweb.css  |    2 +
    19	 gitweb/gitweb.perl |  165 ++++++++++++++++++++++++++++++++...
    20	 2 files changed, 117 insertions(+), 50 deletions(-)

I do not think we need to show 1..15 at all, perhaps without
"export GIT_MERGE_BASE_DEBUG=YesPlease".

  reply	other threads:[~2007-01-13  0:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04 10:47 [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-04 12:33 ` Johannes Schindelin
2007-01-04 12:47   ` Alex Riesen
2007-01-04 20:22     ` Junio C Hamano
2007-01-05 11:22       ` Alex Riesen
2007-01-07 16:31         ` Alex Riesen
2007-01-10 18:06           ` Junio C Hamano
2007-01-10 19:28           ` Junio C Hamano
2007-01-10 22:11             ` Junio C Hamano
2007-01-10 23:07             ` Alex Riesen
2007-01-10 23:23               ` Linus Torvalds
2007-01-11  8:14                 ` Johannes Schindelin
2007-01-11  9:03                   ` Alex Riesen
2007-01-11 12:11                     ` Alex Riesen
2007-01-11 20:37                       ` Junio C Hamano
2007-01-11  9:02                 ` Alex Riesen
2007-01-11 16:38                   ` Linus Torvalds
2007-01-11 17:43                     ` Alex Riesen
2007-01-11 18:02                       ` Linus Torvalds
2007-01-11 21:48                         ` Alex Riesen
2007-01-11 20:23                     ` Junio C Hamano
2007-01-11 22:10                       ` Alex Riesen
2007-01-11 22:28                         ` Linus Torvalds
2007-01-11 23:53                           ` Junio C Hamano
2007-01-12  0:18                           ` Alex Riesen
2007-01-11  0:34               ` Junio C Hamano
2007-01-11  8:15             ` Johannes Schindelin
2007-01-12 15:48             ` Sergey Vlasov
2007-01-12 17:38               ` Alex Riesen
2007-01-12 20:37                 ` Sergey Vlasov
2007-01-12 18:23               ` Junio C Hamano
2007-01-12 20:09                 ` [PATCH] merge-recursive: do not report the resulting tree object name Junio C Hamano
2007-01-12 23:36                   ` Johannes Schindelin
2007-01-13  0:32                     ` Junio C Hamano [this message]
2007-01-13  0:57                       ` Jakub Narebski
2007-01-13 11:01                         ` Johannes Schindelin
2007-01-13  5:14                       ` Shawn O. Pearce
2007-01-13  7:03                         ` Junio C Hamano
2007-01-12 20:30                 ` [PATCH] Speedup recursive by flushing index only once for all entries Alex Riesen
2007-01-12 21:07                 ` Sergey Vlasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vbql3pxz8.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.