All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
	kou.ishizaki@toshiba.co.jp, benh@kernel.crashing.org,
	arnd@arndb.de, paulus@samba.org, linas@austin.ibm.com
Subject: Re: [PATCH 0/4] drivers/ata: add low-level I/O calls
Date: Fri, 12 Jan 2007 10:24:06 +0000	[thread overview]
Message-ID: <20070112102406.6eb9374f@localhost.localdomain> (raw)
In-Reply-To: <200701120958.l0C9wICB019343@toshiba.co.jp>

On Fri, 12 Jan 2007 19:00:45 +0900
Akira Iguchi <akira2.iguchi@toshiba.co.jp> wrote:

> Dear everyone,
> 
> This is the patchset (based on 2.6.20-rc4) to add low-level I/O calls
> which access the taskfile registers. The idea comes from drivers/ide
> IN*/OUT* calls.

I think this is the wrong approach. The existing code provides methods
for things like "read the status", "write a taskfile" and this is the
style that should be kept.

Alan

WARNING: multiple messages have this Message-ID (diff)
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: arnd@arndb.de, linuxppc-dev@ozlabs.org,
	linux-ide@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH 0/4] drivers/ata: add low-level I/O calls
Date: Fri, 12 Jan 2007 10:24:06 +0000	[thread overview]
Message-ID: <20070112102406.6eb9374f@localhost.localdomain> (raw)
In-Reply-To: <200701120958.l0C9wICB019343@toshiba.co.jp>

On Fri, 12 Jan 2007 19:00:45 +0900
Akira Iguchi <akira2.iguchi@toshiba.co.jp> wrote:

> Dear everyone,
> 
> This is the patchset (based on 2.6.20-rc4) to add low-level I/O calls
> which access the taskfile registers. The idea comes from drivers/ide
> IN*/OUT* calls.

I think this is the wrong approach. The existing code provides methods
for things like "read the status", "write a taskfile" and this is the
style that should be kept.

Alan

  reply	other threads:[~2007-01-12 10:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 10:00 [PATCH 0/4] drivers/ata: add low-level I/O calls Akira Iguchi
2007-01-12 10:24 ` Alan [this message]
2007-01-12 10:24   ` Alan
2007-01-12 10:41   ` Benjamin Herrenschmidt
2007-01-12 10:41     ` Benjamin Herrenschmidt
2007-01-12 16:58 ` Jeff Garzik
2007-01-12 16:58   ` Jeff Garzik
2007-01-12 20:50   ` Benjamin Herrenschmidt
2007-01-12 20:50     ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2007-01-12 10:00 Akira Iguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070112102406.6eb9374f@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akira2.iguchi@toshiba.co.jp \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=kou.ishizaki@toshiba.co.jp \
    --cc=linas@austin.ibm.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.