vt1617a build ops

vt1617a build ops

[Daniel Jacobowitz]

This patch connects the extra vt1616 controls for the vt1617a, which
is necessary to control the rear speakers on e.g. a Shuttle SN25P.

Signed-off-by: Daniel Jacobowitz <drow@false.org>

diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
index e813968..025a60e 100644
--- a/sound/pci/ac97/ac97_patch.c
+++ b/sound/pci/ac97/ac97_patch.c
@@ -2821,6 +2823,7 @@ int patch_vt1617a(struct snd_ac97 * ac97)
 	snd_ac97_write_cache(ac97, 0x5c, 0x20);
 	ac97->ext_id |= AC97_EI_SPDIF;	/* force the detection of spdif */
 	ac97->rates[AC97_RATES_SPDIF] = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000;
+	ac97->build_ops = &patch_vt1616_ops;
 	return 0;
 }
 

-- 
Daniel Jacobowitz
CodeSourcery

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: vt1617a build ops

[Takashi Iwai]

At Fri, 12 Jan 2007 11:36:29 -0500,
Daniel Jacobowitz wrote:
> 
> This patch connects the extra vt1616 controls for the vt1617a, which
> is necessary to control the rear speakers on e.g. a Shuttle SN25P.
> 
> Signed-off-by: Daniel Jacobowitz <drow@false.org>

Can this be applied independently from your ganged controls patch,
right?


Takashi


> 
> diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
> index e813968..025a60e 100644
> --- a/sound/pci/ac97/ac97_patch.c
> +++ b/sound/pci/ac97/ac97_patch.c
> @@ -2821,6 +2823,7 @@ int patch_vt1617a(struct snd_ac97 * ac97)
>  	snd_ac97_write_cache(ac97, 0x5c, 0x20);
>  	ac97->ext_id |= AC97_EI_SPDIF;	/* force the detection of spdif */
>  	ac97->rates[AC97_RATES_SPDIF] = SNDRV_PCM_RATE_44100 | SNDRV_PCM_RATE_48000;
> +	ac97->build_ops = &patch_vt1616_ops;
>  	return 0;
>  }
>  
> 
> -- 
> Daniel Jacobowitz
> CodeSourcery
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: vt1617a build ops

[Daniel Jacobowitz]

On Fri, Jan 12, 2007 at 05:58:39PM +0100, Takashi Iwai wrote:
> At Fri, 12 Jan 2007 11:36:29 -0500,
> Daniel Jacobowitz wrote:
> > 
> > This patch connects the extra vt1616 controls for the vt1617a, which
> > is necessary to control the rear speakers on e.g. a Shuttle SN25P.
> > 
> > Signed-off-by: Daniel Jacobowitz <drow@false.org>
> 
> Can this be applied independently from your ganged controls patch,
> right?

Yes, it just adds the new controls (Alternate Level to Surround Out,
Downmix LFE and Center to Front, Downmix Surround to Front).  Then
you can fix them; the default power-on settings are wrong for 5.1.

-- 
Daniel Jacobowitz
CodeSourcery

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: vt1617a build ops

[Takashi Iwai]

At Fri, 12 Jan 2007 12:43:39 -0500,
Daniel Jacobowitz wrote:
> 
> On Fri, Jan 12, 2007 at 05:58:39PM +0100, Takashi Iwai wrote:
> > At Fri, 12 Jan 2007 11:36:29 -0500,
> > Daniel Jacobowitz wrote:
> > > 
> > > This patch connects the extra vt1616 controls for the vt1617a, which
> > > is necessary to control the rear speakers on e.g. a Shuttle SN25P.
> > > 
> > > Signed-off-by: Daniel Jacobowitz <drow@false.org>
> > 
> > Can this be applied independently from your ganged controls patch,
> > right?
> 
> Yes, it just adds the new controls (Alternate Level to Surround Out,
> Downmix LFE and Center to Front, Downmix Surround to Front).  Then
> you can fix them; the default power-on settings are wrong for 5.1.

OK, now applied to ALSA tree.  Thanks!


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV