cmipci patch

cmipci patch

[Felix Hammer]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

hi

according to this bug --> 
https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2491
i attached the diff for commit.

regards
felix
_______________________________________
http://www.lehrsaiten.de
http://sourceforge.net/projects/pokerth

[-- Attachment #2: cmipci.diff --]
[-- Type: text/x-diff, Size: 448 bytes --]

--- alsa-driver-hg20070119/alsa-kernel/pci/cmipci.c	2006-12-21 02:00:15.000000000 +0100
+++ cmipci.c	2007-01-19 10:46:37.000000000 +0100
@@ -2779,6 +2779,13 @@
 	struct snd_opl3 *opl3;
 	int err;
 
+ 
+ 	if ( fm_port == 0 ) {
+ 		snd_cmipci_clear_bit(cm, CM_REG_MISC_CTRL, CM_FM_EN);
+ 		return 0;
+ 	}
+ 
+
 	/* first try FM regs in PCI port range */
 	iosynth = cm->iobase + CM_REG_FM_PCI;
 	err = snd_opl3_create(cm->card, iosynth, iosynth + 2,

[-- Attachment #3: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: cmipci patch

[Takashi Iwai]

At Fri, 19 Jan 2007 11:22:05 +0100,
Felix Hammer wrote:
> 
> hi
> 
> according to this bug --> 
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=2491
> i attached the diff for commit.

The patch looks OK, but please follow the standard coding style of the
linux kernel, namely, remove spaces around parentheses.
Also, give a proper changelog and a sign-off to merge.
(See the main page of ALSA BTS.)


thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV