Re: [PATCH 13/14] NLM: Shrink the maximum request size of NLM4 requests

[Christoph Hellwig <hch@infradead.org>]

On Fri, Jan 19, 2007 at 05:27:13PM -0500, Chuck Lever wrote:
> Christoph Hellwig wrote:
> >On Thu, Jan 18, 2007 at 06:30:56PM -0500, Chuck Lever wrote:
> >>NLM version 4 requests estimate the call and reply header sizes rather
> >>conservatively, using the very maximum size allowed in the protocol even
> >>though Linux always uses only a small fraction of the allowable space.
> >>
> >>Reduce the size of caller and lock arguments to conserve RPC buffer space
> >>while XDR encoding NLM4 arguments..
> >
> >>+#ifndef MIN
> >>+# define MIN(a, b)	(((a) < (b)) ? (a) : (b))
> >>+#endif
> >
> >please use the kernel min or min_t macros instead.
> 
> min/min_t don't work for integer constants, which is what I'm using 
> MIN() for.  What should I use instead?

I suspect the right thing is to fix min/max/min_t/max_t for it using gcc
hackery like __builtin_constant_p.  Then again I don't understand enough
of that nor do I expect you to know this deep magic.  So Let's keep one
MIN/MAX in some central sunrpc header for now and add a block comment
describing why you need it.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs