Re: [PATCH 14/14] SUNRPC: Debugging aid

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

Trond Myklebust wrote:
> On Thu, 2007-01-18 at 18:31 -0500, Chuck Lever wrote:
>> Add helper functions for tracking the current FSM state for each RPC task.
>> The FSM state name is now displayed in rpc_show_task instead of the
>> absolute address of the FSM function.
>>
> 
> Urgh. When are we ever going to need this information?
> 
> We already have the tk_action pointer and the rpc_queue.

The tk_action pointer is useless in cases where we don't have a symbol 
map.  I've actually run into this problem in the field.

In rpc_show_tasks, I was going to do a ksymbol mapping of tk_action, and 
print the symbol name instead of the function pointer.  Unfortunately 
the ksymbol stuff just doesn't work when sunrpc is loaded as a module.

I considered your idea of replacing "tk_action = call_yada;" with a 
function or macro that would also update tk_action_name, but I think we 
get more accurate information by setting tk_action_name right at the top 
of each state function.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 276 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture Linux Projects Group
email;internet:chuck dot lever at nospam oracle dot com
title:Principle Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 347 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs