* [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
@ 2007-01-23 15:17 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-01-23 15:17 UTC (permalink / raw)
To: Giuliano Pochini, perex; +Cc: alsa-devel, linux-kernel
Despite being under linux/, linux/irq.h shouldn't be #include'd by arch
independent code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c.old 2007-01-23 15:16:37.000000000 +0100
+++ linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c 2007-01-23 14:22:49.000000000 +0100
@@ -39,7 +39,7 @@
static int write_control_reg(struct echoaudio *chip, u32 ctl, u32 frq,
char force);
-#include <linux/irq.h>
+#include <linux/interrupt.h>
static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
{
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
@ 2007-01-23 15:17 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-01-23 15:17 UTC (permalink / raw)
To: Giuliano Pochini, perex; +Cc: alsa-devel, linux-kernel
Despite being under linux/, linux/irq.h shouldn't be #include'd by arch
independent code.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c.old 2007-01-23 15:16:37.000000000 +0100
+++ linux-2.6.20-rc4-mm1/sound/pci/echoaudio/echo3g_dsp.c 2007-01-23 14:22:49.000000000 +0100
@@ -39,7 +39,7 @@
static int write_control_reg(struct echoaudio *chip, u32 ctl, u32 frq,
char force);
-#include <linux/irq.h>
+#include <linux/interrupt.h>
static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
{
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
2007-01-23 15:17 ` Adrian Bunk
(?)
@ 2007-01-23 18:24 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2007-01-23 18:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: alsa-devel, perex, Giuliano Pochini, linux-kernel
At Tue, 23 Jan 2007 16:17:56 +0100,
Adrian Bunk wrote:
>
> Despite being under linux/, linux/irq.h shouldn't be #include'd by arch
> independent code.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, I applied to ALSA tree now.
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Alsa-devel] [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h>
2007-01-23 15:17 ` Adrian Bunk
(?)
(?)
@ 2007-01-23 18:24 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2007-01-23 18:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Giuliano Pochini, perex, alsa-devel, linux-kernel
At Tue, 23 Jan 2007 16:17:56 +0100,
Adrian Bunk wrote:
>
> Despite being under linux/, linux/irq.h shouldn't be #include'd by arch
> independent code.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, I applied to ALSA tree now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-23 18:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-23 15:17 [2.6 patch] echo3g_dsp.c shouldn't include #include <linux/irq.h> Adrian Bunk
2007-01-23 15:17 ` Adrian Bunk
2007-01-23 18:24 ` Takashi Iwai
2007-01-23 18:24 ` [Alsa-devel] " Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.