From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: nfs@lists.sourceforge.net, trond.myklebust@fys.uio.no
Subject: Re: [PATCH 13/15] SUNRPC: RPC buffer size estimates are too large
Date: Wed, 24 Jan 2007 16:25:01 -0500 [thread overview]
Message-ID: <20070124212501.GG6587@fieldses.org> (raw)
In-Reply-To: <45B7CB0A.5040505@oracle.com>
On Wed, Jan 24, 2007 at 04:09:30PM -0500, Chuck Lever wrote:
> These values are just for estimating the largest size the buffers will
> need to be for this call and reply. Alignment issues need to be handled
> somewhere else.
OK, I'm an idiot--so cslack is just for calculating the maximum size,
rslack is for placing the data correctly. So now I understand what
you're doing, and don't see any more problem with it.
> >This is padding at a different level--the plaintext usually has to be
> >padded to the nearest block size (at least 8 bytes) before encryption.
>
> That doesn't sound like XDR at all. I don't see how RPC buffer
> allocation could be concerned about this...
The encrypted data is encapsulated in xdr and the RPC buffers need to be
large enough to hold them.
But all we need to do is make gss's au_cslack value big enough for the
worst case and we're fine, OK.
--b.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-01-24 21:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-24 19:17 [PATCH 00/15] patches for 2.6.21 Chuck Lever
2007-01-24 19:19 ` [PATCH 01/15] NFS: fix print format for tk_pid Chuck Lever
2007-01-24 19:19 ` [PATCH 02/15] SUNRPC: fix print format for tk_pid in auth_gss support Chuck Lever
2007-01-24 19:19 ` [PATCH 03/15] SUNRPC: fix print format for tk_pid Chuck Lever
2007-01-24 19:19 ` [PATCH 04/15] SUNRPC: Eliminate side effects from rpc_malloc Chuck Lever
2007-01-24 19:19 ` [PATCH 05/15] SUNRPC: Make rpc_free API more generic Chuck Lever
2007-01-24 19:19 ` [PATCH 06/15] NFS: disconnect before retrying NFSv4 requests over TCP Chuck Lever
2007-01-24 19:20 ` [PATCH 07/15] SUNRPC: introduce rpcbind: replacement for in-kernel portmapper Chuck Lever
2007-01-24 19:20 ` [PATCH 08/15] SUNRPC: switch socket-based RPC transports to use rpcbind Chuck Lever
2007-01-24 19:20 ` [PATCH 09/15] SUNRPC: switch the RPC server to use the new rpcbind registration API Chuck Lever
2007-01-24 19:20 ` [PATCH 10/15] NFS: switch NFSROOT to use new rpcbind client Chuck Lever
2007-01-24 19:20 ` [PATCH 11/15] SUNRPC: remove old portmapper Chuck Lever
2007-01-24 19:20 ` [PATCH 12/15] SUNRPC: RPC client should retry with different versions of rpcbind Chuck Lever
2007-01-24 19:20 ` [PATCH 13/15] SUNRPC: RPC buffer size estimates are too large Chuck Lever
2007-01-24 20:37 ` J. Bruce Fields
2007-01-24 20:41 ` Chuck Lever
2007-01-24 20:51 ` J. Bruce Fields
2007-01-24 21:09 ` Chuck Lever
2007-01-24 21:25 ` J. Bruce Fields [this message]
2007-01-24 21:28 ` Chuck Lever
2007-01-24 20:47 ` J. Bruce Fields
2007-01-24 20:50 ` Chuck Lever
2007-01-24 21:01 ` J. Bruce Fields
2007-01-24 21:11 ` Chuck Lever
2007-01-24 19:20 ` [PATCH 14/15] NLM: Shrink the maximum request size of NLM4 requests Chuck Lever
2007-01-24 19:20 ` [PATCH 15/15] SUNRPC: Debugging aid Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070124212501.GG6587@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.