All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Track mlock()ed pages
Date: Fri, 26 Jan 2007 10:10:27 -0800	[thread overview]
Message-ID: <20070126101027.90bf3e63.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0701260742340.6141@schroedinger.engr.sgi.com>

On Fri, 26 Jan 2007 07:44:42 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:

> On Fri, 26 Jan 2007, Andrew Morton wrote:
> 
> > > > > Track mlocked pages via a ZVC
> > 
> > Why?
> 
> Large amounts of mlocked pages may be a problem for 
> 
> 1. Reclaim behavior.
> 
> 2. Defragmentation
> 

We know that.  What has that to do with this patch?

> 
> > You could perhaps go for a walk across all the other vmas which presently
> > map this page.  If any of them have VM_LOCKED, don't increment the counter.
> > Similar on removal: only decrement the counter when the final mlocked VMA
> > is dropping the pte.
> 
> For that we would need an additional refcount for vmlocked maps in the 
> page struct.

No you don't.  The refcount is already there.  It is "the sum of the VM_LOCKED
VMAs which map this page".

It might be impractical or expensive to calculate it, but it's there.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] Track mlock()ed pages
Date: Fri, 26 Jan 2007 10:10:27 -0800	[thread overview]
Message-ID: <20070126101027.90bf3e63.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0701260742340.6141@schroedinger.engr.sgi.com>

On Fri, 26 Jan 2007 07:44:42 -0800 (PST)
Christoph Lameter <clameter@sgi.com> wrote:

> On Fri, 26 Jan 2007, Andrew Morton wrote:
> 
> > > > > Track mlocked pages via a ZVC
> > 
> > Why?
> 
> Large amounts of mlocked pages may be a problem for 
> 
> 1. Reclaim behavior.
> 
> 2. Defragmentation
> 

We know that.  What has that to do with this patch?

> 
> > You could perhaps go for a walk across all the other vmas which presently
> > map this page.  If any of them have VM_LOCKED, don't increment the counter.
> > Similar on removal: only decrement the counter when the final mlocked VMA
> > is dropping the pte.
> 
> For that we would need an additional refcount for vmlocked maps in the 
> page struct.

No you don't.  The refcount is already there.  It is "the sum of the VM_LOCKED
VMAs which map this page".

It might be impractical or expensive to calculate it, but it's there.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-01-26 18:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-26  5:43 [RFC] Track mlock()ed pages Christoph Lameter
2007-01-26  5:43 ` Christoph Lameter
2007-01-26  6:30 ` Nick Piggin
2007-01-26  6:30   ` Nick Piggin
2007-01-26  6:36   ` Christoph Lameter
2007-01-26  6:36     ` Christoph Lameter
2007-01-26 11:13     ` Andrew Morton
2007-01-26 11:13       ` Andrew Morton
2007-01-26 12:00       ` Nick Piggin
2007-01-26 12:00         ` Nick Piggin
2007-01-26 15:44       ` Christoph Lameter
2007-01-26 15:44         ` Christoph Lameter
2007-01-26 18:10         ` Andrew Morton [this message]
2007-01-26 18:10           ` Andrew Morton
2007-01-26 18:21           ` KAMEZAWA Hiroyuki
2007-01-26 18:21             ` KAMEZAWA Hiroyuki
2007-01-26 18:23           ` Christoph Lameter
2007-01-26 18:23             ` Christoph Lameter
2007-01-26 18:42             ` Andrew Morton
2007-01-26 18:42               ` Andrew Morton
2007-01-27 22:19               ` Rik van Riel
2007-01-27 22:19                 ` Rik van Riel
2007-01-27 22:30                 ` Andrew Morton
2007-01-27 22:30                   ` Andrew Morton
2007-01-27 22:36                   ` Rik van Riel
2007-01-27 22:36                     ` Rik van Riel
2007-01-26 11:46     ` Nick Piggin
2007-01-26 11:46       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070126101027.90bf3e63.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.