From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Filesystems <linux-fsdevel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch 9/9] mm: fix pagecache write deadlocks
Date: Mon, 29 Jan 2007 12:11:15 +0100 [thread overview]
Message-ID: <20070129111115.GA14504@wotan.suse.de> (raw)
In-Reply-To: <20070129082030.23584.72376.sendpatchset@linux.site>
On Mon, Jan 29, 2007 at 11:33:03AM +0100, Nick Piggin wrote:
> + } else {
> + char *src, *dst;
> + src = kmap(src_page);
> + dst = kmap(page);
> + memcpy(dst + offset,
> + src + ((unsigned long)buf & ~PAGE_CACHE_MASK),
> + bytes);
> + kunmap(page);
> + kunmap(src_page);
> + copied = bytes;
> + }
> flush_dcache_page(page);
Hmm, I guess these should use kmap_atomic with KM_USER[01]?
The kmap is from an earlier iteration that wanted to sleep
with the page mapped into kernel.
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Filesystems <linux-fsdevel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch 9/9] mm: fix pagecache write deadlocks
Date: Mon, 29 Jan 2007 12:11:15 +0100 [thread overview]
Message-ID: <20070129111115.GA14504@wotan.suse.de> (raw)
In-Reply-To: <20070129082030.23584.72376.sendpatchset@linux.site>
On Mon, Jan 29, 2007 at 11:33:03AM +0100, Nick Piggin wrote:
> + } else {
> + char *src, *dst;
> + src = kmap(src_page);
> + dst = kmap(page);
> + memcpy(dst + offset,
> + src + ((unsigned long)buf & ~PAGE_CACHE_MASK),
> + bytes);
> + kunmap(page);
> + kunmap(src_page);
> + copied = bytes;
> + }
> flush_dcache_page(page);
Hmm, I guess these should use kmap_atomic with KM_USER[01]?
The kmap is from an earlier iteration that wanted to sleep
with the page mapped into kernel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-29 11:11 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 10:31 [patch 0/9] buffered write deadlock fix Nick Piggin
2007-01-29 10:31 ` Nick Piggin
2007-01-29 10:31 ` [patch 1/9] fs: libfs buffered write leak fix Nick Piggin
2007-01-29 10:31 ` Nick Piggin
2007-02-02 23:52 ` Andrew Morton
2007-02-02 23:52 ` Andrew Morton
2007-02-03 1:33 ` Nick Piggin
2007-02-03 1:33 ` Nick Piggin
2007-02-03 1:58 ` Andrew Morton
2007-02-03 1:58 ` Andrew Morton
2007-02-03 2:09 ` Nick Piggin
2007-02-03 2:09 ` Nick Piggin
2007-02-03 2:19 ` Andrew Morton
2007-02-03 2:19 ` Andrew Morton
2007-02-03 2:28 ` Nick Piggin
2007-02-03 2:28 ` Nick Piggin
2007-02-03 17:49 ` Jörn Engel
2007-02-03 17:49 ` Jörn Engel
2007-02-04 3:55 ` Nick Piggin
2007-02-04 3:55 ` Nick Piggin
2007-02-04 3:55 ` Nick Piggin
2007-01-29 10:31 ` [patch 2/9] mm: revert "generic_file_buffered_write(): handle zero length iovec segments" Nick Piggin
2007-01-29 10:31 ` Nick Piggin, Andrew Morton
2007-01-29 10:32 ` [patch 3/9] mm: revert "generic_file_buffered_write(): deadlock on vectored write" Nick Piggin
2007-01-29 10:32 ` Nick Piggin, Andrew Morton
2007-01-29 10:32 ` [patch 4/9] mm: generic_file_buffered_write cleanup Nick Piggin
2007-01-29 10:32 ` Nick Piggin, Andrew Morton
2007-01-29 10:32 ` [patch 5/9] mm: debug write deadlocks Nick Piggin
2007-01-29 10:32 ` Nick Piggin
2007-01-29 10:32 ` [patch 6/9] mm: be sure to trim blocks Nick Piggin
2007-01-29 10:32 ` Nick Piggin
2007-01-29 10:32 ` [patch 7/9] mm: cleanup pagecache insertion operations Nick Piggin
2007-01-29 10:32 ` Nick Piggin
2007-01-29 10:32 ` [patch 8/9] mm: generic_file_buffered_write iovec cleanup Nick Piggin
2007-01-29 10:32 ` Nick Piggin
2007-01-29 10:33 ` [patch 9/9] mm: fix pagecache write deadlocks Nick Piggin
2007-01-29 10:33 ` Nick Piggin
2007-01-29 11:11 ` Nick Piggin [this message]
2007-01-29 11:11 ` Nick Piggin
2007-02-02 23:53 ` Andrew Morton
2007-02-02 23:53 ` Andrew Morton
2007-02-03 1:38 ` Nick Piggin
2007-02-03 1:38 ` Nick Piggin
2007-01-30 20:55 ` [patch 0/9] buffered write deadlock fix Andrew Morton
2007-01-30 20:55 ` Andrew Morton
2007-01-30 23:21 ` Andrew Morton
2007-01-30 23:21 ` Andrew Morton
2007-01-31 1:31 ` Nick Piggin
2007-01-31 1:31 ` Nick Piggin
2007-01-31 0:32 ` Nick Piggin
2007-01-31 0:32 ` Nick Piggin
2007-02-02 23:52 ` Andrew Morton
2007-02-02 23:52 ` Andrew Morton
2007-02-03 1:22 ` Nick Piggin
2007-02-03 1:22 ` Nick Piggin
2007-02-03 6:43 ` Suparna Bhattacharya
2007-02-03 6:43 ` Suparna Bhattacharya
2007-02-03 15:31 ` Fengguang Wu
2007-02-03 15:31 ` Fengguang Wu
2007-02-03 15:31 ` Fengguang Wu
-- strict thread matches above, loose matches on Subject: below --
2007-02-04 8:49 Nick Piggin
2007-02-04 8:51 ` [patch 9/9] mm: fix pagecache write deadlocks Nick Piggin
2007-02-04 8:51 ` Nick Piggin
2007-02-04 9:44 ` Andrew Morton
2007-02-04 9:44 ` Andrew Morton
2007-02-04 10:15 ` Nick Piggin
2007-02-04 10:15 ` Nick Piggin
2007-02-04 10:26 ` Christoph Hellwig
2007-02-04 10:26 ` Christoph Hellwig
2007-02-04 10:30 ` Andrew Morton
2007-02-04 10:30 ` Andrew Morton
2007-02-04 10:46 ` Nick Piggin
2007-02-04 10:46 ` Nick Piggin
2007-02-04 10:50 ` Nick Piggin
2007-02-04 10:50 ` Nick Piggin
2007-02-04 10:56 ` Andrew Morton
2007-02-04 10:56 ` Andrew Morton
2007-02-04 11:03 ` Nick Piggin
2007-02-04 11:03 ` Nick Piggin
2007-02-04 11:15 ` Andrew Morton
2007-02-04 11:15 ` Andrew Morton
2007-02-04 15:10 ` Nick Piggin
2007-02-04 15:10 ` Nick Piggin
2007-02-04 18:36 ` Andrew Morton
2007-02-04 18:36 ` Andrew Morton
2007-02-06 2:25 ` Nick Piggin
2007-02-06 2:25 ` Nick Piggin
2007-02-06 4:41 ` Nick Piggin
2007-02-06 4:41 ` Nick Piggin
2007-02-06 5:30 ` Andrew Morton
2007-02-06 5:30 ` Andrew Morton
2007-02-06 5:49 ` Nick Piggin
2007-02-06 5:49 ` Nick Piggin
2007-02-06 5:53 ` Nick Piggin
2007-02-06 5:53 ` Nick Piggin
2007-02-04 10:59 ` Anton Altaparmakov
2007-02-04 10:59 ` Anton Altaparmakov
2007-02-04 11:10 ` Andrew Morton
2007-02-04 11:10 ` Andrew Morton
2007-02-04 11:22 ` Nick Piggin
2007-02-04 11:22 ` Nick Piggin
2007-02-04 17:40 ` Anton Altaparmakov
2007-02-04 17:40 ` Anton Altaparmakov
2007-02-06 2:09 ` Nick Piggin
2007-02-06 2:09 ` Nick Piggin
2007-02-06 13:13 ` Anton Altaparmakov
2007-02-06 13:13 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070129111115.GA14504@wotan.suse.de \
--to=npiggin@suse.de \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.