From: Alan Cox <alan@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: cleanup release_mem
Date: Mon, 29 Jan 2007 07:01:00 -0500 [thread overview]
Message-ID: <20070129120100.GA4338@devserv.devel.redhat.com> (raw)
In-Reply-To: <20070128171244.GA21378@lst.de>
On Sun, Jan 28, 2007 at 06:12:44PM +0100, Christoph Hellwig wrote:
> release_mem contains two copies of exactly the same code. Refactor
> these into a new helper, release_tty. The only change in behaviour
> is that the driver reference count is now decremented after the
> master tty has been freed instead of before.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Alan Cox <alan@redhat.com>
Please propogate the mutex_ FIXME comment to both functions as it may
well need to cover tty->link
next prev parent reply other threads:[~2007-01-29 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 17:12 [PATCH] tty: cleanup release_mem Christoph Hellwig
2007-01-29 12:01 ` Alan Cox [this message]
2007-01-29 18:12 ` Christoph Hellwig
2007-01-29 19:06 ` Alan Cox
2007-01-30 3:56 ` Andrew Morton
2007-01-30 6:33 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2007-01-31 7:16 Pekka J Enberg
2007-01-31 14:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070129120100.GA4338@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.