From: Mark Fasheh <mark.fasheh@oracle.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Hugh Dickins <hugh@veritas.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
Anton Altaparmakov <aia21@cam.ac.uk>
Subject: Re: page_mkwrite caller is racy?
Date: Mon, 29 Jan 2007 17:51:59 -0800 [thread overview]
Message-ID: <20070130015159.GA14799@ca-server1.us.oracle.com> (raw)
In-Reply-To: <45BE9BF0.10202@yahoo.com.au>
On Tue, Jan 30, 2007 at 12:14:24PM +1100, Nick Piggin wrote:
> This is another discussion, but do we want the page locked here? Or
> are the filesystems happy to exclude truncate themselves?
No page lock please. Generally, Ocfs2 wants to order cluster locks outside
of page locks. Also, the sparse b-tree support I'm working on right now will
need to be able to allocate in ->page_mkwrite() which would become very
nasty if we came in with the page lock - aside from the additional cluster
locks taken, ocfs2 will want to zero some adjacent pages (because we support
atomic allocation up to 1 meg).
Thanks,
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
WARNING: multiple messages have this Message-ID (diff)
From: Mark Fasheh <mark.fasheh@oracle.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Hugh Dickins <hugh@veritas.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>,
David Howells <dhowells@redhat.com>,
Andrew Morton <akpm@osdl.org>,
Anton Altaparmakov <aia21@cam.ac.uk>
Subject: Re: page_mkwrite caller is racy?
Date: Mon, 29 Jan 2007 17:51:59 -0800 [thread overview]
Message-ID: <20070130015159.GA14799@ca-server1.us.oracle.com> (raw)
In-Reply-To: <45BE9BF0.10202@yahoo.com.au>
On Tue, Jan 30, 2007 at 12:14:24PM +1100, Nick Piggin wrote:
> This is another discussion, but do we want the page locked here? Or
> are the filesystems happy to exclude truncate themselves?
No page lock please. Generally, Ocfs2 wants to order cluster locks outside
of page locks. Also, the sparse b-tree support I'm working on right now will
need to be able to allocate in ->page_mkwrite() which would become very
nasty if we came in with the page lock - aside from the additional cluster
locks taken, ocfs2 will want to zero some adjacent pages (because we support
atomic allocation up to 1 meg).
Thanks,
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-30 1:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 10:20 page_mkwrite caller is racy? Nick Piggin
2007-01-29 10:20 ` Nick Piggin
2007-01-29 16:08 ` Hugh Dickins
2007-01-29 16:08 ` Hugh Dickins
2007-01-29 20:41 ` Anton Altaparmakov
2007-01-29 20:41 ` Anton Altaparmakov
2007-01-30 1:14 ` Nick Piggin
2007-01-30 1:14 ` Nick Piggin
2007-01-30 1:51 ` Mark Fasheh [this message]
2007-01-30 1:51 ` Mark Fasheh
2007-01-30 14:58 ` Anton Altaparmakov
2007-01-30 14:58 ` Anton Altaparmakov
2007-01-31 1:18 ` Nick Piggin
2007-01-31 1:18 ` Nick Piggin
2007-02-01 11:44 ` David Howells
2007-02-01 11:44 ` David Howells
2007-01-29 20:00 ` Mark Fasheh
2007-01-29 20:00 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130015159.GA14799@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.