From: Jens Osterkamp <jens@de.ibm.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
James K Lewis <jim@jklewis.com>,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
jgarzik@pobox.com, cbe-oss-dev@ozlabs.org
Subject: Re: spidernet: add improved phy support in sungem_phy.c
Date: Thu, 1 Feb 2007 11:55:48 +0100 [thread overview]
Message-ID: <200702011155.48664.jens@de.ibm.com> (raw)
In-Reply-To: <20070130223050.GE5616@austin.ibm.com>
On Tuesday 30 January 2007 11:30 pm, Linas Vepstas wrote:
> Shifting to the right by 5 bits has no effect on the result
> of this conditional. Either the bit is set, or its not.
> There is no need to shift.
>
> > + if ( (phy_reg & 0x0020) >> 7 ) {
You are right, I corrected this.
> The result here will always be zero, since the bit,
> if set, will be shifted off the end. Bits on the lef
> are padded with zero. Ergo, this is a bug.
You are right, wrong bit. I corrected this.
Jens
WARNING: multiple messages have this Message-ID (diff)
From: Jens Osterkamp <jens@de.ibm.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ishizaki Kou <kou.ishizaki@toshiba.co.jp>,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
cbe-oss-dev@ozlabs.org, jgarzik@pobox.com,
James K Lewis <jim@jklewis.com>
Subject: Re: spidernet: add improved phy support in sungem_phy.c
Date: Thu, 1 Feb 2007 11:55:48 +0100 [thread overview]
Message-ID: <200702011155.48664.jens@de.ibm.com> (raw)
In-Reply-To: <20070130223050.GE5616@austin.ibm.com>
On Tuesday 30 January 2007 11:30 pm, Linas Vepstas wrote:
> Shifting to the right by 5 bits has no effect on the result
> of this conditional. Either the bit is set, or its not.
> There is no need to shift.
>
> > + if ( (phy_reg & 0x0020) >> 7 ) {
You are right, I corrected this.
> The result here will always be zero, since the bit,
> if set, will be shifted off the end. Bits on the lef
> are padded with zero. Ergo, this is a bug.
You are right, wrong bit. I corrected this.
Jens
next prev parent reply other threads:[~2007-02-01 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 13:07 spidernet: add improved phy support in sungem_phy.c Jens Osterkamp
2007-01-26 13:07 ` Jens Osterkamp
2007-01-26 20:20 ` Benjamin Herrenschmidt
2007-01-26 20:20 ` Benjamin Herrenschmidt
2007-01-26 22:31 ` Jens Osterkamp
2007-01-26 22:31 ` Jens Osterkamp
2007-01-26 23:38 ` Francois Romieu
2007-01-26 23:38 ` Francois Romieu
2007-01-30 22:30 ` Linas Vepstas
2007-01-30 22:30 ` Linas Vepstas
2007-02-01 10:55 ` Jens Osterkamp [this message]
2007-02-01 10:55 ` Jens Osterkamp
2007-02-01 10:57 ` [PATCH] [v2] spidernet: add improved phy support Jens Osterkamp
2007-02-01 10:57 ` Jens Osterkamp
2007-02-01 10:54 ` spidernet: add improved phy support in sungem_phy.c Jens Osterkamp
2007-02-01 10:54 ` Jens Osterkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702011155.48664.jens@de.ibm.com \
--to=jens@de.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jgarzik@pobox.com \
--cc=jim@jklewis.com \
--cc=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.