From: linas@austin.ibm.com (Linas Vepstas)
To: Jens Osterkamp <jens@de.ibm.com>
Cc: netdev@vger.kernel.org, cbe-oss-dev@ozlabs.org,
linuxppc-dev@ozlabs.org, jgarzik@pobox.com,
James K Lewis <jim@jklewis.com>
Subject: Re: [PATCH] spidernet : fix memory leak in spider_net_stop
Date: Thu, 1 Feb 2007 11:36:18 -0600 [thread overview]
Message-ID: <20070201173618.GI5616@austin.ibm.com> (raw)
In-Reply-To: <200702011207.47421.jens@de.ibm.com>
A variant of this patch is queued up for 2.6.21,
as a part of the patch
http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html
I beleive its in the -mm tree, I have not checked.
--linas
On Thu, Feb 01, 2007 at 12:07:47PM +0100, Jens Osterkamp wrote:
>
> We forget to call spider_net_free_rx_chain_contents which does the
> actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache
> on each "ifconfig up" letting the cache grow infinitely.
>
> This patch fixes it.
>
> Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
>
> Index: linux-2.6.20-rc6/drivers/net/spider_net.c
> ===================================================================
> --- linux-2.6.20-rc6.orig/drivers/net/spider_net.c
> +++ linux-2.6.20-rc6/drivers/net/spider_net.c
> @@ -1925,6 +1925,8 @@ spider_net_stop(struct net_device *netde
> /* release chains */
> spider_net_release_tx_chain(card, 1);
>
> + spider_net_free_rx_chain_contents(card);
> +
> spider_net_free_chain(card, &card->tx_chain);
> spider_net_free_chain(card, &card->rx_chain);
>
WARNING: multiple messages have this Message-ID (diff)
From: linas@austin.ibm.com (Linas Vepstas)
To: Jens Osterkamp <jens@de.ibm.com>
Cc: James K Lewis <jim@jklewis.com>,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
jgarzik@pobox.com, cbe-oss-dev@ozlabs.org,
Ishizaki Kou <kou.ishizaki@toshiba.co.jp>
Subject: Re: [PATCH] spidernet : fix memory leak in spider_net_stop
Date: Thu, 1 Feb 2007 11:36:18 -0600 [thread overview]
Message-ID: <20070201173618.GI5616@austin.ibm.com> (raw)
In-Reply-To: <200702011207.47421.jens@de.ibm.com>
A variant of this patch is queued up for 2.6.21,
as a part of the patch
http://www.mail-archive.com/netdev@vger.kernel.org/msg28213.html
I beleive its in the -mm tree, I have not checked.
--linas
On Thu, Feb 01, 2007 at 12:07:47PM +0100, Jens Osterkamp wrote:
>
> We forget to call spider_net_free_rx_chain_contents which does the
> actual dev_kfree_skb. New skbs are allocated from skbuff_head_cache
> on each "ifconfig up" letting the cache grow infinitely.
>
> This patch fixes it.
>
> Signed-off-by: Jens Osterkamp <jens@de.ibm.com>
>
> Index: linux-2.6.20-rc6/drivers/net/spider_net.c
> ===================================================================
> --- linux-2.6.20-rc6.orig/drivers/net/spider_net.c
> +++ linux-2.6.20-rc6/drivers/net/spider_net.c
> @@ -1925,6 +1925,8 @@ spider_net_stop(struct net_device *netde
> /* release chains */
> spider_net_release_tx_chain(card, 1);
>
> + spider_net_free_rx_chain_contents(card);
> +
> spider_net_free_chain(card, &card->tx_chain);
> spider_net_free_chain(card, &card->rx_chain);
>
next prev parent reply other threads:[~2007-02-01 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 11:07 [PATCH] spidernet : fix memory leak in spider_net_stop Jens Osterkamp
2007-02-01 17:36 ` Linas Vepstas [this message]
2007-02-01 17:36 ` Linas Vepstas
2007-02-01 20:40 ` Jens Osterkamp
2007-02-01 20:40 ` Jens Osterkamp
2007-02-02 13:34 ` Jeff Garzik
2007-02-02 13:34 ` Jeff Garzik
2007-02-08 4:15 ` Ishizaki Kou
2007-02-08 4:15 ` Ishizaki Kou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070201173618.GI5616@austin.ibm.com \
--to=linas@austin.ibm.com \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jens@de.ibm.com \
--cc=jgarzik@pobox.com \
--cc=jim@jklewis.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.