All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Andrew Morton <akpm@osdl.org>
Cc: John Keller <jpk@sgi.com>,
	linux-acpi@vger.kernel.org, ayoung@sgi.com,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, "Luck,
	Tony" <tony.luck@intel.com>
Subject: Re: [PATCH 1/1] -  Altix: more ACPI PRT support
Date: Fri, 2 Feb 2007 21:56:42 -0500	[thread overview]
Message-ID: <200702022156.42805.lenb@kernel.org> (raw)
In-Reply-To: <20070202173746.9fc66172.akpm@linux-foundation.org>

On Friday 02 February 2007 20:37, Andrew Morton wrote:
> On Fri, 02 Feb 2007 14:54:12 -0600
> John Keller <jpk@sgi.com> wrote:
> 
> > The SN Altix platform does not conform to the 
> > IOSAPIC IRQ routing model. Add code in acpi_unregister_gsi()
> > to check if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM) and
> > return.
> > 
> > Signed-off-by: John Keller <jpk@sgi.com>
> > ---
> > 
> > Due to an oversight, this code was not added previously when
> > similar code was added to acpi_register_gsi().
> > 
> > http://marc.theaimsgroup.com/?l=linux-acpi&m=116680983430121&w=2
> > 
> >  arch/ia64/kernel/acpi.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > 
> > Index: linux-2.6/arch/ia64/kernel/acpi.c
> > ===================================================================
> > --- linux-2.6.orig/arch/ia64/kernel/acpi.c	2007-02-02 14:44:31.000000000 -0600
> > +++ linux-2.6/arch/ia64/kernel/acpi.c	2007-02-02 14:47:44.658143727 -0600
> > @@ -609,6 +609,9 @@ EXPORT_SYMBOL(acpi_register_gsi);
> >  
> >  void acpi_unregister_gsi(u32 gsi)
> >  {
> > +	if (acpi_irq_model == ACPI_IRQ_MODEL_PLATFORM)
> > +		return;
> > +
> >  	iosapic_unregister_intr(gsi);
> >  }
> 
> Given that the December 22 patch appears to be in mainline, and that this
> patch is simple, I shall cheerily bypass maintainers and send it in for
> 2.6.20.

Yep.

Acked-by: Len Brown <len.brown@intel.com>

thanks,
-Len


WARNING: multiple messages have this Message-ID (diff)
From: Len Brown <lenb@kernel.org>
To: Andrew Morton <akpm@osdl.org>
Cc: John Keller <jpk@sgi.com>,
	linux-acpi@vger.kernel.org, ayoung@sgi.com,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, "Luck,
	Tony" <tony.luck@intel.com>
Subject: Re: [PATCH 1/1] -  Altix: more ACPI PRT support
Date: Sat, 03 Feb 2007 02:56:42 +0000	[thread overview]
Message-ID: <200702022156.42805.lenb@kernel.org> (raw)
In-Reply-To: <20070202173746.9fc66172.akpm@linux-foundation.org>

On Friday 02 February 2007 20:37, Andrew Morton wrote:
> On Fri, 02 Feb 2007 14:54:12 -0600
> John Keller <jpk@sgi.com> wrote:
> 
> > The SN Altix platform does not conform to the 
> > IOSAPIC IRQ routing model. Add code in acpi_unregister_gsi()
> > to check if (acpi_irq_model = ACPI_IRQ_MODEL_PLATFORM) and
> > return.
> > 
> > Signed-off-by: John Keller <jpk@sgi.com>
> > ---
> > 
> > Due to an oversight, this code was not added previously when
> > similar code was added to acpi_register_gsi().
> > 
> > http://marc.theaimsgroup.com/?l=linux-acpi&m\x116680983430121&w=2
> > 
> >  arch/ia64/kernel/acpi.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > 
> > Index: linux-2.6/arch/ia64/kernel/acpi.c
> > =================================> > --- linux-2.6.orig/arch/ia64/kernel/acpi.c	2007-02-02 14:44:31.000000000 -0600
> > +++ linux-2.6/arch/ia64/kernel/acpi.c	2007-02-02 14:47:44.658143727 -0600
> > @@ -609,6 +609,9 @@ EXPORT_SYMBOL(acpi_register_gsi);
> >  
> >  void acpi_unregister_gsi(u32 gsi)
> >  {
> > +	if (acpi_irq_model = ACPI_IRQ_MODEL_PLATFORM)
> > +		return;
> > +
> >  	iosapic_unregister_intr(gsi);
> >  }
> 
> Given that the December 22 patch appears to be in mainline, and that this
> patch is simple, I shall cheerily bypass maintainers and send it in for
> 2.6.20.

Yep.

Acked-by: Len Brown <len.brown@intel.com>

thanks,
-Len


  reply	other threads:[~2007-02-03  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-02 20:54 [PATCH 1/1] - Altix: more ACPI PRT support John Keller
2007-02-02 20:54 ` John Keller
2007-02-03  1:37 ` Andrew Morton
2007-02-03  1:37   ` Andrew Morton
2007-02-03  2:56   ` Len Brown [this message]
2007-02-03  2:56     ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200702022156.42805.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=akpm@osdl.org \
    --cc=ayoung@sgi.com \
    --cc=jpk@sgi.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.