All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix rtl8150
@ 2007-02-04  2:59 Al Viro
  0 siblings, 0 replies; only message in thread
From: Al Viro @ 2007-02-04  2:59 UTC (permalink / raw)
  To: torvald; +Cc: linux-kernel, linux-usb-users

	That code doesn't do what its author apparently thought
it would do...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/usb/net/rtl8150.c b/drivers/usb/net/rtl8150.c
index e0eecda..670262a 100644
--- a/drivers/usb/net/rtl8150.c
+++ b/drivers/usb/net/rtl8150.c
@@ -284,7 +284,8 @@ static int write_mii_word(rtl8150_t * dev, u8 phy, __u8 indx, u16 reg)
 	u8 data[3], tmp;
 
 	data[0] = phy;
-	*(data + 1) = cpu_to_le16p(&reg);
+	data[1] = reg & 0xff;
+	data[2] = (reg >> 8) & 0xff;
 	tmp = indx | PHY_WRITE | PHY_GO;
 	i = 0;
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-02-04  2:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-04  2:59 [PATCH] fix rtl8150 Al Viro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.