Re: [patch] pvfb: Split mouse and keyboard into separate devices.

["Daniel P. Berrange" <berrange@redhat.com>]

On Wed, Feb 07, 2007 at 03:31:24PM +0100, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@suse.de> writes:
> 
> >   Hi,
> >
> > This patch creates two separate input devices for keyboard and mouse
> > events.  Also includes some key bitmap fixes (allow all keyboard keys,
> > allow eight mouse buttons).
> >
> > I hope everyone is happy with that now after the lengthy discussion ;)
> >
> > please apply,
> >   Gerd
> >
> > -- 
> > Gerd Hoffmann <kraxel@suse.de>
> > pvfb: Split mouse and keyboard into separate devices.
> >
> > This patch creates two separate input devices for keyboard and mouse
> > events.  The reason for this is to separate them in the linux input
> > layer and allow them being routed different ways.
> >
> > Use case:  Configure the X-Server like this to get the mouse
> > events directly from the linux input layer, which has the major
> > advantage that absolute coordinates work correctly:
> >
> > Section "InputDevice"
> >   Driver       "evdev"
> >   Identifier   "Mouse"
> >   Option       "Device" "/dev/input/event<nr>"
> > EndSection
> >
> > This makes the keyboard stop working though in case mouse and
> > keyboard events are coming through the same input device, at least
> > with older Xorg (6.9) versions.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
> 
> New, not mentioned in the changelog:
> 
> * Initialization of struct input_dev members phys, id.bustype,
>   id.vendor, id.product.
> 
> * Take care of the FIXME regarding initialization struct input_dev
>   member keybit (thanks!).
> 
> * Take care of the TODO to enable all pointer buttons.  Perhaps should
>   better go in together with the fix to tools/xenfb/vncfb.c posted by
>   Daniel.

Yep, the kernel portion of my patches are obsoleted by Gerd's updated 
patch. The userspace portion still needs applying.

I've no objections to Gerd's patch being applied.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|