From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Michael Chan" <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [TG3 1/8]: Save MSI state before suspend.
Date: Tue, 13 Feb 2007 11:58:25 -0800 [thread overview]
Message-ID: <20070213115825.0a6119ed@freekitty> (raw)
In-Reply-To: <1171397612.18944.25.camel@rh4>
On Tue, 13 Feb 2007 12:13:32 -0800
"Michael Chan" <mchan@broadcom.com> wrote:
> [TG3]: Save MSI state before suspend.
>
> This fixes the following problem:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=7969
>
> The MSI state needs to be saved during suspend. PCI state saved
> during tg3_init_one() does not contain valid MSI state because
> MSI hasn't been enabled.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
>
I think you have to move the original pci_save_state call, otherwise
you will call pci_save_state twice and leak memory. pci_save_state
allocates memory to store MSI and other information. Look at pci_save_pcie_state
etc.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-02-13 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 20:13 [TG3 1/8]: Save MSI state before suspend Michael Chan
2007-02-13 19:45 ` Jeff Garzik
2007-02-13 20:34 ` Michael Chan
2007-02-13 19:58 ` Stephen Hemminger [this message]
2007-02-13 20:01 ` Jeff Garzik
2007-02-13 20:54 ` Michael Chan
2007-02-13 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213115825.0a6119ed@freekitty \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.