From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Michael Chan <mchan@broadcom.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [TG3 1/8]: Save MSI state before suspend.
Date: Tue, 13 Feb 2007 15:01:24 -0500 [thread overview]
Message-ID: <20070213200124.GD16991@havoc.gtf.org> (raw)
In-Reply-To: <20070213115825.0a6119ed@freekitty>
On Tue, Feb 13, 2007 at 11:58:25AM -0800, Stephen Hemminger wrote:
> I think you have to move the original pci_save_state call, otherwise
> you will call pci_save_state twice and leak memory. pci_save_state
> allocates memory to store MSI and other information. Look at pci_save_pcie_state
> etc.
That's a bug in the PCI layer. Patches welcome...
Jeff
next prev parent reply other threads:[~2007-02-13 20:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 20:13 [TG3 1/8]: Save MSI state before suspend Michael Chan
2007-02-13 19:45 ` Jeff Garzik
2007-02-13 20:34 ` Michael Chan
2007-02-13 19:58 ` Stephen Hemminger
2007-02-13 20:01 ` Jeff Garzik [this message]
2007-02-13 20:54 ` Michael Chan
2007-02-13 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070213200124.GD16991@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.