renaming in debugfs?

renaming in debugfs?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

For the wiphy stuff I wanted to provide a debugfs as well as a sysfs dir
for drivers (or the d80211 stack).

But then I decided that stable wiphy names will be a good thing instead
of just numbering them wiphy%d. Does anyone have any idea how to rename
directories in debugfs? I guess that for sysfs it'll just work if I
change the kobject name, but maybe that's wrong too?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: renaming in debugfs?

[Greg KH]

On Thu, Feb 15, 2007 at 12:52:53PM +0100, Johannes Berg wrote:
> For the wiphy stuff I wanted to provide a debugfs as well as a sysfs dir
> for drivers (or the d80211 stack).
> 
> But then I decided that stable wiphy names will be a good thing instead
> of just numbering them wiphy%d. Does anyone have any idea how to rename
> directories in debugfs? I guess that for sysfs it'll just work if I
> change the kobject name, but maybe that's wrong too?

No, use kobject_rename() if you want to rename a kobject in sysfs (or
the real device_rename() call if you have a struct device).

For debugfs, there is no rename function yet, but it would be pretty
trivial to add one if you wish.

thanks,

greg k-h

Re: renaming in debugfs?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

On Thu, 2007-02-15 at 14:40 -0800, Greg KH wrote:
> On Thu, Feb 15, 2007 at 12:52:53PM +0100, Johannes Berg wrote:
> > For the wiphy stuff I wanted to provide a debugfs as well as a sysfs dir
> > for drivers (or the d80211 stack).
> > 
> > But then I decided that stable wiphy names will be a good thing instead
> > of just numbering them wiphy%d. Does anyone have any idea how to rename
> > directories in debugfs? I guess that for sysfs it'll just work if I
> > change the kobject name, but maybe that's wrong too?
> 
> No, use kobject_rename() if you want to rename a kobject in sysfs (or
> the real device_rename() call if you have a struct device).

Ok.

> For debugfs, there is no rename function yet, but it would be pretty
> trivial to add one if you wish.

Alright, when I get around to actually doing renaming in cfg80211 (it's
not really high priority right now) it I'll check out how it would be
done.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: renaming in debugfs?

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Thu, 2007-02-15 at 14:40 -0800, Greg KH wrote:

> For debugfs, there is no rename function yet, but it would be pretty
> trivial to add one if you wish.

I tried to, but failed.
http://johannes.sipsolutions.net/patches/debugfs-rename.patch

does absolutely nothing at all, not even return an error! What am I
doing wrong? :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]