From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert.Uytterhoeven@sonycom.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-fbdev-devel@lists.sourceforge.net,
Christoph Hellwig <hch@lst.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [patch 1/4] ps3fb: thread updates
Date: Fri, 16 Feb 2007 17:36:15 +0100 [thread overview]
Message-ID: <20070216163615.GA32051@lst.de> (raw)
In-Reply-To: <20070215165916.de546f0d.akpm@linux-foundation.org>
On Thu, Feb 15, 2007 at 04:59:16PM -0800, Andrew Morton wrote:
> No, it won't get you out of down_interruptible(). But the code would have
> failed trivial testing so perhaps we're missing something.
>
> It seems crufty to use semaphores in this manner. afaict all we're doing
> here is poking a kernel thread and asking it to do a bit of work. The
> standard way of doing this is to go to sleep on a waitqueue_head.
We don't even need the waitqueue. Because it's just a single thread
waiting we can simply use wake_up_process. (.. which you actually
used in the second half of the example, humm..)
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Geert.Uytterhoeven@sonycom.com,
linux-fbdev-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [patch 1/4] ps3fb: thread updates
Date: Fri, 16 Feb 2007 17:36:15 +0100 [thread overview]
Message-ID: <20070216163615.GA32051@lst.de> (raw)
In-Reply-To: <20070215165916.de546f0d.akpm@linux-foundation.org>
On Thu, Feb 15, 2007 at 04:59:16PM -0800, Andrew Morton wrote:
> No, it won't get you out of down_interruptible(). But the code would have
> failed trivial testing so perhaps we're missing something.
>
> It seems crufty to use semaphores in this manner. afaict all we're doing
> here is poking a kernel thread and asking it to do a bit of work. The
> standard way of doing this is to go to sleep on a waitqueue_head.
We don't even need the waitqueue. Because it's just a single thread
waiting we can simply use wake_up_process. (.. which you actually
used in the second half of the example, humm..)
next prev parent reply other threads:[~2007-02-16 16:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 15:23 [patch 0/4] PS3 AV/FB updates Geert.Uytterhoeven
2007-02-15 15:23 ` Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 1/4] ps3fb: thread updates Geert.Uytterhoeven
2007-02-15 15:23 ` Geert.Uytterhoeven
2007-02-15 17:50 ` Christoph Hellwig
2007-02-15 17:50 ` Christoph Hellwig
2007-02-15 21:43 ` Benjamin Herrenschmidt
2007-02-16 0:59 ` Andrew Morton
2007-02-16 15:58 ` Geert Uytterhoeven
2007-02-16 15:58 ` Geert Uytterhoeven
2007-02-16 16:00 ` [PATCH 1/4 (updated)] " Geert Uytterhoeven
2007-02-16 16:00 ` Geert Uytterhoeven
2007-02-16 16:38 ` Christoph Hellwig
2007-02-16 16:38 ` Christoph Hellwig
2007-02-16 17:33 ` Geert Uytterhoeven
2007-02-16 17:33 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2007-02-19 14:07 ` Geert Uytterhoeven
2007-02-20 10:33 ` Geert Uytterhoeven
2007-02-20 10:42 ` [PATCH 1/4 (final?)] " Geert Uytterhoeven
2007-02-21 23:20 ` Andrew Morton
2007-02-21 23:20 ` Andrew Morton
2007-02-22 8:21 ` Geert Uytterhoeven
2007-02-22 8:21 ` Geert Uytterhoeven
2007-02-22 12:16 ` Geert Uytterhoeven
2007-02-22 12:16 ` Geert Uytterhoeven
2007-02-22 12:17 ` [PATCH 1/4 (final)] " Geert Uytterhoeven
2007-02-22 12:17 ` Geert Uytterhoeven
2007-02-16 16:03 ` [PATCH extra] ps3fb: atomic fixes Geert Uytterhoeven
2007-02-16 16:03 ` Geert Uytterhoeven
2007-02-16 16:36 ` Christoph Hellwig [this message]
2007-02-16 16:36 ` [patch 1/4] ps3fb: thread updates Christoph Hellwig
2007-02-15 15:23 ` [patch 2/4] ps3av: " Geert.Uytterhoeven
2007-02-15 15:23 ` Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 3/4] ps3fb: kill superfluous zero initializations Geert.Uytterhoeven
2007-02-15 15:23 ` Geert.Uytterhoeven
2007-02-15 15:23 ` [patch 4/4] ps3av: misc updates Geert.Uytterhoeven
2007-02-15 15:23 ` Geert.Uytterhoeven
2007-02-15 15:48 ` [patch 0/4] PS3 AV/FB updates James Simmons
2007-02-15 15:48 ` [Linux-fbdev-devel] " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070216163615.GA32051@lst.de \
--to=hch@lst.de \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.