Re: [PATCH] (pata-2.6 fix queue) cmd64x: procfs code fixes/cleanups

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 15 February 2007 20:17, Sergei Shtylyov wrote:
> Fix several issues with the driver's procfs output:
> 
> - when testing if channel is enabled, the code looks at the "simplex" bits, not
>   at the real enable bits -- add #define for the primary channel enable bit;
> 
> - UltraDMA modes 0, 1, 3 for slave drive reported incorrectly due to using the
>   master drive's clock cycle resolution bit.
> 
> While at it, also perform some cleanups:
> 
> - don't read from the registers which are not used for dump;
> 
> - correct the chipset names (from CMDxxx to PCI-xxx);
> 
> - rework UltraDMA mode dump code;
> 
> - remove PIO mode dump code that has never been finished;
> 
> - remove the duplicate interrupt status dump (the MRDMODE register bits mirror
>   those in the CFR and ARTTIM23 registers);
> 
> - add spaces in the ?: operators...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied