From: Chris Mason <chris.mason@oracle.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Benjamin LaHaise <bcrl@kvack.org>,
"Ananiev, Leonid I" <leonid.i.ananiev@intel.com>,
Zach Brown <zach.brown@oracle.com>,
linux-aio@kvack.org, linux-kernel@vger.kernel.org,
Suparna bhattacharya <suparna@in.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event
Date: Tue, 20 Feb 2007 11:19:48 -0500 [thread overview]
Message-ID: <20070220161948.GQ6133@think.oraclecorp.com> (raw)
In-Reply-To: <1171987607.3531.142.camel@laptopd505.fenrus.org>
On Tue, Feb 20, 2007 at 05:06:47PM +0100, Arjan van de Ven wrote:
> > We don't try to resolve "conflicting" writes between ordinary mmap() and
> > write(), so why should we be doing it for mmap and O_DIRECT?
> >
> > mmap() is designed to violate the ordinary mutex locks for write(), so
> > if a conflict arises, whether it be with O_DIRECT or ordinary writes
> > then it is a case of "last writer wins".
>
> but.. wouldn't an O_DIRECT *read* even cause this?
The O_DIRECT read is fine because it doesn't leave bad data in the page
cache. The point of doing invalidate_inode_pages2_range is to purge
page cache data that has the old contents of the file before the
O_DIRECT write.
-chris
next prev parent reply other threads:[~2007-02-20 16:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-19 20:35 [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event Zach Brown
2007-02-19 20:47 ` Benjamin LaHaise
2007-02-19 21:07 ` Zach Brown
2007-02-19 20:58 ` Ananiev, Leonid I
2007-02-19 21:50 ` Chris Mason
2007-02-20 0:21 ` Benjamin LaHaise
2007-02-20 0:26 ` Zach Brown
2007-02-20 0:28 ` Chris Mason
2007-02-20 16:01 ` Trond Myklebust
2007-02-20 16:06 ` Benjamin LaHaise
2007-02-20 16:06 ` Arjan van de Ven
2007-02-20 16:19 ` Chris Mason [this message]
2007-02-20 16:08 ` Chris Mason
2007-02-20 16:29 ` Trond Myklebust
2007-02-20 16:38 ` Trond Myklebust
2007-02-20 18:40 ` Zach Brown
2007-02-21 0:05 ` Trond Myklebust
2007-02-20 14:08 ` Ananiev, Leonid I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070220161948.GQ6133@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=bcrl@kvack.org \
--cc=leonid.i.ananiev@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
--cc=trond.myklebust@fys.uio.no \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.