All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	john stultz <johnstul@us.ibm.com>,
	Roman Zippel <zippel@linux-m68k.org>,
	Mike Galbraith <efault@gmx.de>,
	Ken Chen <kenneth.w.chen@intel.com>,
	balducci@units.it, LKML <linux-kernel@vger.kernel.org>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value
Date: Thu, 22 Feb 2007 08:46:24 +0100	[thread overview]
Message-ID: <20070222074624.GA9800@elte.hu> (raw)
In-Reply-To: <1172104409.25076.165.camel@localhost.localdomain>


* Thomas Gleixner <tglx@linutronix.de> wrote:

> The problem is that the p->last_ran value is not updated after a 
> context switch. So a subsequent call to current_sched_time() 
> calculates with a stale p->last_ran value, i.e. accounts the full 
> time, which the task was scheduled away.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

>  	sched_info_switch(prev, next);
>  	if (likely(prev != next)) {
> -		next->timestamp = now;
> +		next->timestamp = next->last_ran = now;

ouch! nice catch. Also for v2.6.20.2 i think. 2.6.19 should be 
unaffected.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2007-02-22  7:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070221104747.3cb0da32.akpm@linux-foundation.org>
2007-02-22  0:33 ` [PATCH] Fix posix-cpu-timer breakage caused by stale p->last_ran value Thomas Gleixner
2007-02-22  7:46   ` Ingo Molnar [this message]
2007-02-22  8:01     ` Thomas Gleixner
2007-02-22  9:16   ` Mike Galbraith
2007-03-01 23:45   ` Chuck Ebbert
2007-03-02  0:27     ` Andrew Morton
     [not found] <fa.5d4W3Gwb5Gw7ztDfk2utJt1zgjc@ifi.uio.no>
     [not found] ` <fa.cIP2OCge0gIF8cSETEmZ9D2dxpE@ifi.uio.no>
2007-02-22 16:49   ` John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070222074624.GA9800@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=balducci@units.it \
    --cc=efault@gmx.de \
    --cc=greg@kroah.com \
    --cc=johnstul@us.ibm.com \
    --cc=kenneth.w.chen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.