* [PATCH] siimage: DRAC4 note
@ 2007-02-20 17:56 Alan
2007-02-20 16:56 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Alan @ 2007-02-20 17:56 UTC (permalink / raw)
To: bzolnier, linux-kernel
The Dell DRAC4 has some interesting features including effectively hot
unplugging/replugging the virtual CD interface when the DRAC is reset.
This often causes drivers/ide/siimage to panic but is ok with the rather
smarter code in libata.
Just note this fact in the driver docs.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
--- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:38:01.000000000 +0000
+++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:59:44.000000000 +0000
@@ -26,6 +26,9 @@
* If you have strange problems with nVidia chipset systems please
* see the SI support documentation and update your system BIOS
* if neccessary
+ *
+ * If you are using a Dell DRAC4 you should use the libata driver
+ * if possible.
*/
#include <linux/types.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siimage: DRAC4 note
2007-02-20 17:56 [PATCH] siimage: DRAC4 note Alan
@ 2007-02-20 16:56 ` Jeff Garzik
2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-02-20 16:56 UTC (permalink / raw)
To: Alan; +Cc: bzolnier, linux-kernel
Alan wrote:
> The Dell DRAC4 has some interesting features including effectively hot
> unplugging/replugging the virtual CD interface when the DRAC is reset.
> This often causes drivers/ide/siimage to panic but is ok with the rather
> smarter code in libata.
>
> Just note this fact in the driver docs.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
> --- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:38:01.000000000 +0000
> +++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:59:44.000000000 +0000
> @@ -26,6 +26,9 @@
> * If you have strange problems with nVidia chipset systems please
> * see the SI support documentation and update your system BIOS
> * if neccessary
> + *
> + * If you are using a Dell DRAC4 you should use the libata driver
> + * if possible.
IMO it would probably easier on all involved if the comment noted what
you state in the patch description.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siimage: DRAC4 note
2007-02-20 16:56 ` Jeff Garzik
@ 2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz
2007-02-21 1:08 ` Alan
2007-02-21 15:52 ` Alan
0 siblings, 2 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-02-20 18:48 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Alan, linux-kernel
On Tuesday 20 February 2007 17:56, Jeff Garzik wrote:
> Alan wrote:
> > The Dell DRAC4 has some interesting features including effectively hot
> > unplugging/replugging the virtual CD interface when the DRAC is reset.
> > This often causes drivers/ide/siimage to panic but is ok with the rather
> > smarter code in libata.
> >
> > Just note this fact in the driver docs.
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
> >
> > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
> > --- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:38:01.000000000 +0000
> > +++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:59:44.000000000 +0000
> > @@ -26,6 +26,9 @@
> > * If you have strange problems with nVidia chipset systems please
> > * see the SI support documentation and update your system BIOS
> > * if neccessary
> > + *
> > + * If you are using a Dell DRAC4 you should use the libata driver
> > + * if possible.
>
> IMO it would probably easier on all involved if the comment noted what
> you state in the patch description.
seconded
Alan, please send me the actual OOPS if possible.
Bart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] siimage: DRAC4 note
2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz
@ 2007-02-21 1:08 ` Alan
2007-02-21 15:52 ` Alan
1 sibling, 0 replies; 6+ messages in thread
From: Alan @ 2007-02-21 1:08 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-kernel
> > IMO it would probably easier on all involved if the comment noted what
> > you state in the patch description.
>
> seconded
>
> Alan, please send me the actual OOPS if possible.
You have a wide choice of oopses, watchdogs and hangs available.
Basically the device vanishes and in some cases we end up stuck in a
tight loop with the old IDE layer trying to get to talk to it and then
die in an NMI watchdog.
If you are interested in the actual dumps let me know. I'll need to clear
it with originator of the reports.
Alan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] siimage: DRAC4 note
2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz
2007-02-21 1:08 ` Alan
@ 2007-02-21 15:52 ` Alan
2007-02-23 20:11 ` Bartlomiej Zolnierkiewicz
1 sibling, 1 reply; 6+ messages in thread
From: Alan @ 2007-02-21 15:52 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-kernel
Revised DRAC4 warning as Jeff suggested, this one includes more info
about why the problem occurs
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c linux-2.6.20-mm2/drivers/ide/pci/siimage.c
--- linux.vanilla-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-20 13:38:01.000000000 +0000
+++ linux-2.6.20-mm2/drivers/ide/pci/siimage.c 2007-02-21 14:30:08.187487864 +0000
@@ -26,6 +26,11 @@
* If you have strange problems with nVidia chipset systems please
* see the SI support documentation and update your system BIOS
* if neccessary
+ *
+ * The Dell DRAC4 has some interesting features including effectively hot
+ * unplugging/replugging the virtual CD interface when the DRAC is reset.
+ * This often causes drivers/ide/siimage to panic but is ok with the rather
+ * smarter code in libata.
*/
#include <linux/types.h>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-23 20:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-20 17:56 [PATCH] siimage: DRAC4 note Alan
2007-02-20 16:56 ` Jeff Garzik
2007-02-20 18:48 ` Bartlomiej Zolnierkiewicz
2007-02-21 1:08 ` Alan
2007-02-21 15:52 ` Alan
2007-02-23 20:11 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.