From: David Miller <davem@davemloft.net>
To: dmonakhov@openvz.org
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
devel@openvz.org
Subject: Re: [PATCH 3/3] SPARC: Handle request_irq() failure
Date: Mon, 26 Feb 2007 17:44:50 +0000 [thread overview]
Message-ID: <20070226.094450.39157931.davem@davemloft.net> (raw)
In-Reply-To: <87y7mkq4so.fsf@sw.ru>
From: Monakhov Dmitriy <dmonakhov@openvz.org>
Date: Mon, 26 Feb 2007 19:09:27 +0300
> Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
...
> @@ -389,7 +390,12 @@ static int __init ts102_uctrl_init(void)
> if(!driver->irq)
> driver->irq = tmp_irq[0].pri;
>
> - request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + err = request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + if (err) {
> + printk(KERN_ERR "%s: unable to request irq %d\n",
> + __FUNCTION__, driver->irq);
> + return -EBUSY;
> + }
>
Why not return the error code that request_irq() gave us?
That's how I'll fix this bug.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: dmonakhov@openvz.org
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
devel@openvz.org
Subject: Re: [PATCH 3/3] SPARC: Handle request_irq() failure
Date: Mon, 26 Feb 2007 09:44:50 -0800 (PST) [thread overview]
Message-ID: <20070226.094450.39157931.davem@davemloft.net> (raw)
In-Reply-To: <87y7mkq4so.fsf@sw.ru>
From: Monakhov Dmitriy <dmonakhov@openvz.org>
Date: Mon, 26 Feb 2007 19:09:27 +0300
> Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
...
> @@ -389,7 +390,12 @@ static int __init ts102_uctrl_init(void)
> if(!driver->irq)
> driver->irq = tmp_irq[0].pri;
>
> - request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + err = request_irq(driver->irq, uctrl_interrupt, 0, "uctrl", driver);
> + if (err) {
> + printk(KERN_ERR "%s: unable to request irq %d\n",
> + __FUNCTION__, driver->irq);
> + return -EBUSY;
> + }
>
Why not return the error code that request_irq() gave us?
That's how I'll fix this bug.
next prev parent reply other threads:[~2007-02-26 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 16:09 [PATCH 3/3] SPARC: Handle request_irq() failure Monakhov Dmitriy
2007-02-26 16:09 ` Monakhov Dmitriy
2007-02-26 17:44 ` David Miller [this message]
2007-02-26 17:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226.094450.39157931.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.