From: William Lee Irwin III <wli@holomorphy.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linuxppc-dev@ozlabs.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john stultz <johnstul@us.ibm.com>
Subject: Re: Make sure we populate the initroot filesystem late enough
Date: Sun, 25 Feb 2007 22:59:43 -0800 [thread overview]
Message-ID: <20070226065943.GA3037@holomorphy.com> (raw)
In-Reply-To: <1172462466.3971.46.camel@shinybook.infradead.org>
On Sun, Feb 25, 2007 at 11:01:06PM -0500, David Woodhouse wrote:
> Yeah, I did that before giving up on it for the day and going in search
> of dinner. It changes the failure mode to a BUG() in
> cache_free_debugcheck(), at line 2876 of mm/slab.c
> It smells like the pages weren't actually reserved in the first place
> and we were blithely allocating them. The only problem with that theory
> is that the initrd doesn't seem to be getting corrupted -- and if we
> were handing out its pages like that then surely _something_ would have
> scribbled on it before we tried to read it.
> When I head back in tomorrow morning I'll instrument free_initrd_mem()
> to check that the PageReserved bit was actually set on each page, before
> clearing it. And I'll make the page allocation routines check whether
> they're giving out pages between initrd_start and initrd_end, etc.
Another few things to try would be inserting checks in page_alloc.c for
pages in that specific range before some flag set in free_initrd_mem()
is set, and (conflicting with that, though easily reconciled) unmapping
initrd memory in free_initrd_mem() instead of freeing it.
-- wli
WARNING: multiple messages have this Message-ID (diff)
From: William Lee Irwin III <wli@holomorphy.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org, john stultz <johnstul@us.ibm.com>
Subject: Re: Make sure we populate the initroot filesystem late enough
Date: Sun, 25 Feb 2007 22:59:43 -0800 [thread overview]
Message-ID: <20070226065943.GA3037@holomorphy.com> (raw)
In-Reply-To: <1172462466.3971.46.camel@shinybook.infradead.org>
On Sun, Feb 25, 2007 at 11:01:06PM -0500, David Woodhouse wrote:
> Yeah, I did that before giving up on it for the day and going in search
> of dinner. It changes the failure mode to a BUG() in
> cache_free_debugcheck(), at line 2876 of mm/slab.c
> It smells like the pages weren't actually reserved in the first place
> and we were blithely allocating them. The only problem with that theory
> is that the initrd doesn't seem to be getting corrupted -- and if we
> were handing out its pages like that then surely _something_ would have
> scribbled on it before we tried to read it.
> When I head back in tomorrow morning I'll instrument free_initrd_mem()
> to check that the PageReserved bit was actually set on each page, before
> clearing it. And I'll make the page allocation routines check whether
> they're giving out pages between initrd_start and initrd_end, etc.
Another few things to try would be inserting checks in page_alloc.c for
pages in that specific range before some flag set in free_initrd_mem()
is set, and (conflicting with that, though easily reconciled) unmapping
initrd memory in free_initrd_mem() instead of freeing it.
-- wli
next prev parent reply other threads:[~2007-02-26 7:23 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200612112059.kBBKx1j7022473@hera.kernel.org>
2007-02-26 0:00 ` Make sure we populate the initroot filesystem late enough David Woodhouse
2007-02-26 0:00 ` David Woodhouse
2007-02-26 0:24 ` Linus Torvalds
2007-02-26 0:24 ` Linus Torvalds
2007-02-26 0:45 ` David Woodhouse
2007-02-26 0:45 ` David Woodhouse
2007-02-26 1:17 ` David Woodhouse
2007-02-26 1:17 ` David Woodhouse
2007-02-26 3:45 ` Linus Torvalds
2007-02-26 3:45 ` Linus Torvalds
2007-02-26 4:01 ` David Woodhouse
2007-02-26 4:01 ` David Woodhouse
2007-02-26 4:13 ` Linus Torvalds
2007-02-26 4:13 ` Linus Torvalds
2007-02-26 16:24 ` David Woodhouse
2007-02-26 16:24 ` David Woodhouse
2007-02-26 6:59 ` William Lee Irwin III [this message]
2007-02-26 6:59 ` William Lee Irwin III
2007-02-26 15:53 ` Benjamin Herrenschmidt
2007-02-26 15:53 ` Benjamin Herrenschmidt
2007-02-26 16:00 ` Segher Boessenkool
2007-02-26 16:00 ` Segher Boessenkool
2007-02-26 16:44 ` Milton Miller
2007-02-26 16:44 ` Milton Miller
2007-02-26 20:57 ` David Woodhouse
2007-02-26 20:57 ` David Woodhouse
2007-02-26 21:17 ` Linus Torvalds
2007-02-26 21:17 ` Linus Torvalds
2007-02-27 6:46 ` Benjamin Herrenschmidt
2007-02-27 6:46 ` Benjamin Herrenschmidt
2007-02-26 15:51 ` Benjamin Herrenschmidt
2007-02-26 15:51 ` Benjamin Herrenschmidt
2007-02-26 20:51 ` Kumar Gala
2007-02-26 20:51 ` Kumar Gala
2007-02-26 19:27 ` john stultz
2007-02-26 19:27 ` john stultz
2007-02-26 22:27 ` Paul TBBle Hampson
2007-02-26 22:27 ` Paul TBBle Hampson
2007-02-27 6:48 ` Benjamin Herrenschmidt
2007-02-27 6:48 ` Benjamin Herrenschmidt
2007-02-27 11:58 ` Segher Boessenkool
2007-02-27 11:58 ` Segher Boessenkool
2007-02-28 6:43 ` Benjamin Herrenschmidt
2007-02-28 6:43 ` Benjamin Herrenschmidt
2007-02-28 10:13 ` David Woodhouse
2007-02-28 10:13 ` David Woodhouse
2007-03-01 0:30 ` Michael Ellerman
2007-03-01 0:30 ` Michael Ellerman
2007-03-12 23:01 ` Paul TBBle Hampson
2007-03-12 23:01 ` Paul TBBle Hampson
2007-03-13 3:03 ` Kumar Gala
2007-03-13 3:03 ` Kumar Gala
2007-03-13 7:03 ` Benjamin Herrenschmidt
2007-03-13 7:03 ` Benjamin Herrenschmidt
2007-03-16 7:20 ` Paul TBBle Hampson
2007-03-16 7:20 ` Paul TBBle Hampson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070226065943.GA3037@holomorphy.com \
--to=wli@holomorphy.com \
--cc=dwmw2@infradead.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.