Re: [PATCH 2/5] mips: PMC MSP71xx mips common

[Andrew Sharp <tigerand@gmail.com>]

On Tue, Feb 27, 2007 at 09:09:21AM -0800, Marc St-Jean wrote:
> 
> Andrew Sharp wrote:
> > On Mon, 26 Feb 2007 18:12:55 -0600 Marc St-Jean <stjeanma@pmc-sierra.com> wrote:
> >  > diff --git a/include/asm-mips/bootinfo.h b/include/asm-mips/bootinfo.h
> >  > index c7c945b..ab29fd4 100644
> >  > --- a/include/asm-mips/bootinfo.h
> >  > +++ b/include/asm-mips/bootinfo.h
> >  > @@ -213,6 +213,18 @@
> >  >  #define MACH_GROUP_NEC_EMMA2RH 25    /* NEC EMMA2RH (was 23)         */
> >  > #define  MACH_NEC_MARKEINS    0       /* NEC EMMA2RH Mark-eins        */
> >  > +/*
> >  > + * Valid machtype for group PMC-MSP
> >  > + */
> >  > +#define MACH_GROUP_MSP         23    /* PMC-Sierra MSP 
> > boards/CPUs    */
> >  > +#define MACH_MSP4200_EVAL       0    /* PMC-Sierra MSP4200 
> > Evaluation board */
> >  > +#define MACH_MSP4200_GW         1    /* PMC-Sierra MSP4200 Gateway 
> > demo board */
> >  > +#define MACH_MSP4200_FPGA       2    /* PMC-Sierra MSP4200 Emulation 
> > board */
> >  > +#define MACH_MSP7120_EVAL       3    /* PMC-Sierra MSP7120 
> > Evaluation board *
> > /
> >  > +#define MACH_MSP7120_GW         4    /* PMC-Sierra MSP7120 
> > Residential Gateway board */
> >  > +#define MACH_MSP7120_FPGA       5    /* PMC-Sierra MSP7120 Emulation 
> > board */
> >  > +#define MACH_MSP_OTHER        255    /* PMC-Sierra unknown board 
> > type */
> >  > +#define CL_SIZE                      COMMAND_LINE_SIZE
> > 
> > 
> > Really I would add MACH_GROUP_MSP after MACH_GROUP_NEC_EMMA2RH,
> > perhaps 27 or 28, rather than an interior number.  Especially if
> > you are going to put it after MACH_GROUP_NEC_EMMA2RH in the file. ~:^)
> 
> Sure we aren't tied to this number. Looking at the numbering more closely,
> it looks like numbers aren't reused when they are dropped so it may be
> safer in case existing boards are still using 23.
> 
> Why do you recommend 27 or higher when apparently 26 hasn't been used?

Experience. ~:^)  You never know when a little extra room for expansion
might come in handy.  For example, let's say next year you release a
quad-core SOC (hint-hint), and a line of eval boards.  You would have
room to put them in the file next to your other boards.  But just a
suggestion.

Cheers,

a