From: Len Brown <lenb@kernel.org>
To: John Keller <jpk@sgi.com>
Cc: linux-acpi@vger.kernel.org, ayoung@sgi.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] - Altix: reinitialize acpi tables
Date: Thu, 1 Mar 2007 02:36:41 -0500 [thread overview]
Message-ID: <200703010236.42128.lenb@kernel.org> (raw)
In-Reply-To: <20070228234727.11369.38394.sendpatchset@attica.americas.sgi.com>
so will the 1st acpi_table_init() always fail -- even
on future machines?
-Len
On Wednesday 28 February 2007 18:47, John Keller wrote:
> To provide compatibilty with SN kernels that do and do not
> have ACPI IO support, the SN PROM must build different
> versions of some ACPI tables based on which kernel is booting.
> As such, the tables may have to change at kernel boot time.
> By default, prior to kernel boot, the PROM builds an empty
> DSDT (header only) and no SSDTs. If an ACPI capable kernel
> boots, the kernel will notify the PROM, at platform setup time,
> and the PROM will build full DSDT and SSDT tables.
>
> With the latest changes to acpi_table_init(), the table lengths
> are saved, and when our PROM changes them, the changes are not seen,
> and the kernel will crash on boot. Because of issues with kexec support,
> we are not able to create the tables prior to acpi_table_init().
> As a result, we are making a second call to acpi_table_init() to
> process the rebuilt DSDT and SSDTs.
>
> Signed-off-by: John Keller <jpk@sgi.com>
> ---
>
>
> Index: release/arch/ia64/sn/kernel/setup.c
> ===================================================================
> --- release.orig/arch/ia64/sn/kernel/setup.c 2007-02-28 11:02:34.558139870 -0600
> +++ release/arch/ia64/sn/kernel/setup.c 2007-02-28 11:02:39.362737953 -0600
> @@ -397,6 +397,8 @@ void __init sn_setup(char **cmdline_p)
> ia64_sn_set_os_feature(OSF_PCISEGMENT_ENABLE);
> ia64_sn_set_os_feature(OSF_ACPI_ENABLE);
>
> + /* Load the new DSDT and SSDT tables into the global table list. */
> + acpi_table_init();
>
> #if defined(CONFIG_VT) && defined(CONFIG_VGA_CONSOLE)
> /*
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Len Brown <lenb@kernel.org>
To: John Keller <jpk@sgi.com>
Cc: linux-acpi@vger.kernel.org, ayoung@sgi.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] - Altix: reinitialize acpi tables
Date: Thu, 01 Mar 2007 07:36:41 +0000 [thread overview]
Message-ID: <200703010236.42128.lenb@kernel.org> (raw)
In-Reply-To: <20070228234727.11369.38394.sendpatchset@attica.americas.sgi.com>
so will the 1st acpi_table_init() always fail -- even
on future machines?
-Len
On Wednesday 28 February 2007 18:47, John Keller wrote:
> To provide compatibilty with SN kernels that do and do not
> have ACPI IO support, the SN PROM must build different
> versions of some ACPI tables based on which kernel is booting.
> As such, the tables may have to change at kernel boot time.
> By default, prior to kernel boot, the PROM builds an empty
> DSDT (header only) and no SSDTs. If an ACPI capable kernel
> boots, the kernel will notify the PROM, at platform setup time,
> and the PROM will build full DSDT and SSDT tables.
>
> With the latest changes to acpi_table_init(), the table lengths
> are saved, and when our PROM changes them, the changes are not seen,
> and the kernel will crash on boot. Because of issues with kexec support,
> we are not able to create the tables prior to acpi_table_init().
> As a result, we are making a second call to acpi_table_init() to
> process the rebuilt DSDT and SSDTs.
>
> Signed-off-by: John Keller <jpk@sgi.com>
> ---
>
>
> Index: release/arch/ia64/sn/kernel/setup.c
> =================================> --- release.orig/arch/ia64/sn/kernel/setup.c 2007-02-28 11:02:34.558139870 -0600
> +++ release/arch/ia64/sn/kernel/setup.c 2007-02-28 11:02:39.362737953 -0600
> @@ -397,6 +397,8 @@ void __init sn_setup(char **cmdline_p)
> ia64_sn_set_os_feature(OSF_PCISEGMENT_ENABLE);
> ia64_sn_set_os_feature(OSF_ACPI_ENABLE);
>
> + /* Load the new DSDT and SSDT tables into the global table list. */
> + acpi_table_init();
>
> #if defined(CONFIG_VT) && defined(CONFIG_VGA_CONSOLE)
> /*
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2007-03-01 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 23:47 [PATCH 1/1] - Altix: reinitialize acpi tables John Keller
2007-02-28 23:47 ` John Keller
2007-03-01 7:36 ` Len Brown [this message]
2007-03-01 7:36 ` Len Brown
2007-03-01 15:15 ` John Keller
2007-03-01 15:15 ` John Keller
2007-03-01 15:15 ` John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703010236.42128.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=ayoung@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.