From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org, bridge@linux-foundation.org
Subject: Re: [Bridge] [RFC 1/2] bridge: avoid ptype_all packet handling
Date: Fri, 02 Mar 2007 15:41:00 -0800 (PST) [thread overview]
Message-ID: <20070302.154100.30187565.davem@davemloft.net> (raw)
In-Reply-To: <20070302153414.4d8304e0@freekitty>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 2 Mar 2007 15:34:14 -0800
> Can you get FC fixed?
I am not the DHCP package maintainer. :-)
I'm up to my earfulls already dealing with people trying
to slug broken patches into the kernel networking that paper
around application bugs. ;)
> Should we add a warning to kernel log, to make distro's fix it?
Unfortunately it looks like a properly formed sockaddr_ll,
the ifindex is in fact zero, so there is nothing we can do
to warn about this case.
The sockaddr_ll sits after the first sockaddr string in the ifreq, and
the rest remains initialized to zeros, thus the bind() succeeds.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: bridge@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [RFC 1/2] bridge: avoid ptype_all packet handling
Date: Fri, 02 Mar 2007 15:41:00 -0800 (PST) [thread overview]
Message-ID: <20070302.154100.30187565.davem@davemloft.net> (raw)
In-Reply-To: <20070302153414.4d8304e0@freekitty>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 2 Mar 2007 15:34:14 -0800
> Can you get FC fixed?
I am not the DHCP package maintainer. :-)
I'm up to my earfulls already dealing with people trying
to slug broken patches into the kernel networking that paper
around application bugs. ;)
> Should we add a warning to kernel log, to make distro's fix it?
Unfortunately it looks like a properly formed sockaddr_ll,
the ifindex is in fact zero, so there is nothing we can do
to warn about this case.
The sockaddr_ll sits after the first sockaddr string in the ifreq, and
the rest remains initialized to zeros, thus the bind() succeeds.
next prev parent reply other threads:[~2007-03-02 23:41 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-01 1:18 [Bridge] [PATCH] bridge: avoid ptype_all packet handling Stephen Hemminger
2007-03-01 1:18 ` Stephen Hemminger
2007-03-01 1:28 ` [Bridge] " Ben Greear
2007-03-01 1:28 ` Ben Greear
2007-03-01 3:56 ` [Bridge] " Stephen Hemminger
2007-03-01 3:56 ` Stephen Hemminger
2007-03-01 4:05 ` [Bridge] " Ben Greear
2007-03-01 4:05 ` Ben Greear
2007-03-01 7:04 ` [Bridge] " Stephen Hemminger
2007-03-01 7:04 ` Stephen Hemminger
2007-03-01 7:22 ` [Bridge] " David Miller
2007-03-01 7:22 ` David Miller
2007-03-01 7:26 ` [Bridge] " Stephen Hemminger
2007-03-01 7:26 ` Stephen Hemminger
2007-03-01 7:30 ` [Bridge] " David Miller
2007-03-01 7:30 ` David Miller
2007-03-01 11:47 ` [Bridge] " jamal
2007-03-01 11:47 ` jamal
2007-03-03 2:14 ` [Bridge] " Andi Kleen
2007-03-03 2:14 ` Andi Kleen
2007-03-03 4:22 ` [Bridge] " David Miller
2007-03-03 4:22 ` David Miller
2007-03-03 7:09 ` [Bridge] " Stephen Hemminger
2007-03-03 7:09 ` Stephen Hemminger
2007-03-03 12:30 ` [Bridge] " Andi Kleen
2007-03-03 12:30 ` Andi Kleen
2007-03-02 21:26 ` [Bridge] " David Miller
2007-03-02 21:26 ` David Miller
2007-03-02 22:09 ` [Bridge] [RFC 1/2] " Stephen Hemminger
2007-03-02 22:09 ` Stephen Hemminger
2007-03-02 22:14 ` [Bridge] [RFC 2/2] bridge: per device promiscious taps Stephen Hemminger
2007-03-02 22:14 ` Stephen Hemminger
2007-03-02 22:48 ` [Bridge] [RFC 1/2] bridge: avoid ptype_all packet handling David Miller
2007-03-02 22:48 ` David Miller
2007-03-02 23:18 ` [Bridge] " David Miller
2007-03-02 23:18 ` David Miller
2007-03-02 23:34 ` [Bridge] " Stephen Hemminger
2007-03-02 23:34 ` Stephen Hemminger
2007-03-02 23:41 ` David Miller [this message]
2007-03-02 23:41 ` David Miller
2007-03-03 5:38 ` [Bridge] " Herbert Xu
2007-03-03 5:38 ` Herbert Xu
2007-03-03 5:59 ` [Bridge] " David Miller
2007-03-03 5:59 ` David Miller
2007-03-03 6:42 ` [Bridge] " Herbert Xu
2007-03-03 6:42 ` Herbert Xu
2007-03-02 22:15 ` [Bridge] " Stephen Hemminger
2007-03-02 22:15 ` Stephen Hemminger
2007-03-03 12:04 ` [Bridge] [PATCH] " Stefan Rompf
2007-03-03 12:04 ` Stefan Rompf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070302.154100.30187565.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.