From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jayakumar.lkml@gmail.com,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH] fb: fsync() method for deferred I/O flush.
Date: Mon, 5 Mar 2007 19:39:05 +0900 [thread overview]
Message-ID: <20070305103905.GA12601@linux-sh.org> (raw)
There are cases when we do not want to wait on the delay for
automatically updating the "real" framebuffer, this implements a
simple ->fsync() hook for explicitly flushing the deferred I/O
work. The ->page_mkwrite() handler will rearm the work queue
normally.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
drivers/video/fb_defio.c | 12 ++++++++++++
drivers/video/fbmem.c | 3 +++
include/linux/fb.h | 2 ++
3 files changed, 17 insertions(+)
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index c3e57cc..8a66dc8 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -52,6 +52,18 @@ static void fb_deferred_io_work(struct work_struct *work)
mutex_unlock(&fbdefio->lock);
}
+int fb_deferred_io_fsync(struct file *file, struct dentry *dentry, int datasync)
+{
+ struct fb_info *info = file->private_data;
+
+ /* Kill off the delayed work */
+ cancel_rearming_delayed_work(&info->deferred_work);
+
+ /* Run it immediately */
+ return schedule_delayed_work(&info->deferred_work, 0);
+}
+EXPORT_SYMBOL_GPL(fb_deferred_io_fsync);
+
/* vm_ops->page_mkwrite handler */
int fb_deferred_io_mkwrite(struct vm_area_struct *vma,
struct page *page)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 863126a..69bbbe2 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1266,6 +1266,9 @@ static const struct file_operations fb_fops = {
#ifdef HAVE_ARCH_FB_UNMAPPED_AREA
.get_unmapped_area = get_fb_unmapped_area,
#endif
+#ifdef CONFIG_FB_DEFERRED_IO
+ .fsync = fb_deferred_io_fsync,
+#endif
};
struct class *fb_class;
diff --git a/include/linux/fb.h b/include/linux/fb.h
index af217dd..3f62652 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -933,6 +933,8 @@ extern void fb_deferred_io_init(struct fb_info *info);
extern void fb_deferred_io_cleanup(struct fb_info *info);
extern int fb_deferred_io_mkwrite(struct vm_area_struct *vma,
struct page *page);
+extern int fb_deferred_io_fsync(struct file *file, struct dentry *dentry,
+ int datasync);
#else
#define fb_deferred_io_init(fb_info) do { } while (0)
#define fb_deferred_io_cleanup(fb_info) do { } while (0)
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, jayakumar.lkml@gmail.com
Subject: [PATCH] fb: fsync() method for deferred I/O flush.
Date: Mon, 5 Mar 2007 19:39:05 +0900 [thread overview]
Message-ID: <20070305103905.GA12601@linux-sh.org> (raw)
There are cases when we do not want to wait on the delay for
automatically updating the "real" framebuffer, this implements a
simple ->fsync() hook for explicitly flushing the deferred I/O
work. The ->page_mkwrite() handler will rearm the work queue
normally.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
drivers/video/fb_defio.c | 12 ++++++++++++
drivers/video/fbmem.c | 3 +++
include/linux/fb.h | 2 ++
3 files changed, 17 insertions(+)
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
index c3e57cc..8a66dc8 100644
--- a/drivers/video/fb_defio.c
+++ b/drivers/video/fb_defio.c
@@ -52,6 +52,18 @@ static void fb_deferred_io_work(struct work_struct *work)
mutex_unlock(&fbdefio->lock);
}
+int fb_deferred_io_fsync(struct file *file, struct dentry *dentry, int datasync)
+{
+ struct fb_info *info = file->private_data;
+
+ /* Kill off the delayed work */
+ cancel_rearming_delayed_work(&info->deferred_work);
+
+ /* Run it immediately */
+ return schedule_delayed_work(&info->deferred_work, 0);
+}
+EXPORT_SYMBOL_GPL(fb_deferred_io_fsync);
+
/* vm_ops->page_mkwrite handler */
int fb_deferred_io_mkwrite(struct vm_area_struct *vma,
struct page *page)
diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index 863126a..69bbbe2 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -1266,6 +1266,9 @@ static const struct file_operations fb_fops = {
#ifdef HAVE_ARCH_FB_UNMAPPED_AREA
.get_unmapped_area = get_fb_unmapped_area,
#endif
+#ifdef CONFIG_FB_DEFERRED_IO
+ .fsync = fb_deferred_io_fsync,
+#endif
};
struct class *fb_class;
diff --git a/include/linux/fb.h b/include/linux/fb.h
index af217dd..3f62652 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -933,6 +933,8 @@ extern void fb_deferred_io_init(struct fb_info *info);
extern void fb_deferred_io_cleanup(struct fb_info *info);
extern int fb_deferred_io_mkwrite(struct vm_area_struct *vma,
struct page *page);
+extern int fb_deferred_io_fsync(struct file *file, struct dentry *dentry,
+ int datasync);
#else
#define fb_deferred_io_init(fb_info) do { } while (0)
#define fb_deferred_io_cleanup(fb_info) do { } while (0)
next reply other threads:[~2007-03-05 10:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 10:39 Paul Mundt [this message]
2007-03-05 10:39 ` [PATCH] fb: fsync() method for deferred I/O flush Paul Mundt
2007-03-05 11:11 ` Antonino A. Daplas
2007-03-05 11:11 ` [Linux-fbdev-devel] " Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070305103905.GA12601@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.