From: Pavel Machek <pavel@ucw.cz>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, Alan <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] libata: add missing PM callbacks
Date: Tue, 6 Mar 2007 09:22:12 +0100 [thread overview]
Message-ID: <20070306082212.GC2040@elf.ucw.cz> (raw)
In-Reply-To: <45ED22AB.4090901@gmail.com>
Hi!
> > Much complexity for little gain. Who is running _without_ CONFIG_PM
> > these days?
>
> Embedded people, I guess. The problem here is that if we are gonna
> support !CONFIG_PM configuration and try to reduce the kernel/module
> images size for such case, we end up sprinkling #ifdef's all over huge
> number of device drivers.
Ok, in separate mail I see you already did the work...
> If we determine to drop !CONFIG_PM configuration, I'm happy with that
> too but we need to determine something here. Alternatives...
>
> 1. drop !CONFIG_PM configuration
> 2. continue to sprinkle #ifdef's over device drivers
> 3. find out prettier way to mark PM functions
...of 3., and code is nicely generic and fairly simple. I thought it
would be too much work to implemente it, and it would get too messy.
Given that it is so simple, I believe 3. is the best option. We can
still do 1. in future if we feel like so...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-03-06 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 8:30 [PATCH 1/3] libata: add missing PM callbacks Tejun Heo
2007-03-02 8:31 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Tejun Heo
2007-03-02 8:32 ` [PATCH 3/3] libata: add CONFIG_PM to libata core layer Tejun Heo
2007-03-02 12:57 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Alan Cox
2007-03-02 12:02 ` Tejun Heo
2007-03-02 13:19 ` Alan Cox
2007-03-02 12:22 ` Tejun Heo
2007-03-02 12:56 ` [PATCH 1/3] libata: add missing PM callbacks Alan Cox
2007-03-02 23:31 ` Jeff Garzik
2007-03-03 3:11 ` Tejun Heo
2007-03-06 8:05 ` Pavel Machek
2007-03-06 8:13 ` Tejun Heo
2007-03-06 8:22 ` Pavel Machek [this message]
2007-03-06 10:20 ` Andrew Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070306082212.GC2040@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.