From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, Alan <alan@lxorguk.ukuu.org.uk>,
Pavel Machek <pavel@ucw.cz>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] libata: add missing PM callbacks
Date: Sat, 03 Mar 2007 12:11:05 +0900 [thread overview]
Message-ID: <45E8E749.4030406@gmail.com> (raw)
In-Reply-To: <45E8B3C8.2090009@garzik.org>
[cc'ing Pavel and linux-kernel, hello]
Original thread can be read from
http://thread.gmane.org/gmane.linux.ide/16475
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Some LLDs were missing scsi device PM callbacks while having host/port
>> suspend support. Add missing ones.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> applied 1-3, though I agree with Alan that a non-ifdef solution should
> be sought (by the PM & PCI people?), where possible
Agreed, CONFIG_PM ifdefs are all over low level drivers, libata or not,
and ugly as hell. Maybe use separate section, mark functions with
__power and drop them at link time is a better idea. With linker
tricks, we can make references to __power symbols NULL. How does it sound?
--
tejun
next prev parent reply other threads:[~2007-03-03 3:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 8:30 [PATCH 1/3] libata: add missing PM callbacks Tejun Heo
2007-03-02 8:31 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Tejun Heo
2007-03-02 8:32 ` [PATCH 3/3] libata: add CONFIG_PM to libata core layer Tejun Heo
2007-03-02 12:57 ` [PATCH 2/3] libata: add missing CONFIG_PM in LLDs Alan Cox
2007-03-02 12:02 ` Tejun Heo
2007-03-02 13:19 ` Alan Cox
2007-03-02 12:22 ` Tejun Heo
2007-03-02 12:56 ` [PATCH 1/3] libata: add missing PM callbacks Alan Cox
2007-03-02 23:31 ` Jeff Garzik
2007-03-03 3:11 ` Tejun Heo [this message]
2007-03-06 8:05 ` Pavel Machek
2007-03-06 8:13 ` Tejun Heo
2007-03-06 8:22 ` Pavel Machek
2007-03-06 10:20 ` Andrew Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E8E749.4030406@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.