All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] vfs: remove superflous sb == NULL checks
@ 2007-03-07 15:19 Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2007-03-07 15:19 UTC (permalink / raw)
  To: akpm; +Cc: linux-fsdevel

inode->i_sb is always set, not need to check for it.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/fs/inode.c
===================================================================
--- linux-2.6.orig/fs/inode.c	2007-02-24 10:37:57.000000000 +0100
+++ linux-2.6/fs/inode.c	2007-02-24 10:38:50.000000000 +0100
@@ -251,7 +251,7 @@
 	BUG_ON(inode->i_state & I_CLEAR);
 	wait_on_inode(inode);
 	DQUOT_DROP(inode);
-	if (inode->i_sb && inode->i_sb->s_op->clear_inode)
+	if (inode->i_sb->s_op->clear_inode)
 		inode->i_sb->s_op->clear_inode(inode);
 	if (S_ISBLK(inode->i_mode) && inode->i_bdev)
 		bd_forget(inode);
@@ -1041,7 +1041,7 @@
 		if (!(inode->i_state & (I_DIRTY|I_LOCK)))
 			list_move(&inode->i_list, &inode_unused);
 		inodes_stat.nr_unused++;
-		if (!sb || (sb->s_flags & MS_ACTIVE)) {
+		if (sb->s_flags & MS_ACTIVE) {
 			spin_unlock(&inode_lock);
 			return;
 		}
Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c	2007-02-24 10:39:42.000000000 +0100
+++ linux-2.6/fs/ioctl.c	2007-02-24 10:39:53.000000000 +0100
@@ -67,8 +67,6 @@
 			return put_user(res, p);
 		}
 		case FIGETBSZ:
-			if (inode->i_sb == NULL)
-				return -EBADF;
 			return put_user(inode->i_sb->s_blocksize, p);
 		case FIONREAD:
 			return put_user(i_size_read(inode) - filp->f_pos, p);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-07 15:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 15:19 [PATCH] vfs: remove superflous sb == NULL checks Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.