From: David Brownell <david-b@pacbell.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Bryan Wu <bryan.wu@analog.com>,
Andrew Morton <akpm@linux-foundation.org>,
Deepak Saxena <dsaxena@plexity.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-core: i2c bitbang gpio structure
Date: Fri, 9 Mar 2007 09:45:37 -0800 [thread overview]
Message-ID: <200703090945.38880.david-b@pacbell.net> (raw)
In-Reply-To: <20070309175540.6bb22798.khali@linux-fr.org>
On Friday 09 March 2007 8:55 am, Jean Delvare wrote:
> > +struct i2c_bitbang_gpio {
> > + int sda;
> > + int scl;
> > +};
>
> ...
>
> Also, this structure alone isn't very useful. I'm waiting to see
> drivers actually making use of it before I will consider merging this
> patch at all.
The notion would be that we could have one i2c bitbanger using
the CONFIG_GENERIC_GPIO <asm/gpio.h> interfaces that could work
on most platforms, using that struct for platform_data and the
usual convention for platform device naming.
I'd expect that struct would be merged as part of such a generic
GPIO bitbang driver, and would only be used by that one driver.
SPI could use such a generic bitbanger too. Until 2.6.21 it's
been missing that last step: it's needed platform-specific
GPIO calls, so the bitbangers were generic except for those
lowest-level hooks.
- Dave
next prev parent reply other threads:[~2007-03-09 17:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 10:13 [PATCH] i2c-core: i2c bitbang gpio structure Wu, Bryan
2007-03-09 16:55 ` Jean Delvare
2007-03-09 17:45 ` David Brownell [this message]
2007-03-09 18:48 ` [PATCH] Bitbanging i2c bus driver using the GPIO API Haavard Skinnemoen
2007-03-09 19:30 ` David Brownell
2007-03-09 20:08 ` Russell King
2007-03-09 21:17 ` David Brownell
2007-03-09 20:43 ` Håvard Skinnemoen
2007-03-09 21:45 ` David Brownell
2007-03-10 13:13 ` [PATCH v2] " Haavard Skinnemoen
2007-03-10 20:15 ` Jean Delvare
2007-03-11 4:31 ` David Brownell
2007-03-12 14:11 ` Haavard Skinnemoen
2007-03-11 4:02 ` David Brownell
2007-03-12 10:07 ` Wu, Bryan
2007-03-12 14:34 ` Haavard Skinnemoen
2007-03-12 14:53 ` Haavard Skinnemoen
2007-03-12 15:11 ` Jean Delvare
2007-03-12 15:30 ` Haavard Skinnemoen
2007-03-10 19:15 ` [PATCH] " Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703090945.38880.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=dsaxena@plexity.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.